DAT-10314 - Reverts removal of interceptCleanupSpecMethod
#2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aseIntegrationMethodInterceptor. Adds comment.
abrackx
requested review from
nvoxland,
StevenMassaro,
suryaaki2 and
wwillard7800
StevenMassaro
approved these changes
Jun 9, 2022
abrackx
changed the title
interceptCleanupSpecMethodinterceptCleanupSpecMethod
suryaaki2
approved these changes
Jun 10, 2022
nvoxland
approved these changes
Jun 13, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Reverts removal of
interceptCleanupSpecMethodinLiquibaseIntegrationMethodInterceptor. Adds comment explaining use case.Without this change
def cleanupSpec(){}is completely ignored in Spock tests.This was removed in this commit.
Things to be aware of
N/A
Things to worry about
Tests should still pass.
Additional Context