-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix addColumn on mysql when including a "value" attribute #3070
Conversation
@nvoxland apologies if I moved this one around incorrectly; I saw for some reason the linked issue was in Code review, but pretty sure this PR is still in development. I put them both in development. Thanks |
For this PR I did the next tests:
defaultValueBoolean tests
defaultValueComputed tests
defaultValueDate tests
defaultValueNumeric tests
Test environment: |
Impact
Description
Mysql's "alter column" syntax we use to assign the final "not null" constraint to an added column will lose the defaultValue that was set earlier.
Make sure the default value gets re-applied if needed.
Issue introduced in #928
Fixes #2657
Things to be aware of
Things to worry about
defaultValue*
work?