SpringResourceAccessor: fix issue with incorrect match pattern for files from classPath root

[danilmalkin]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Issue #2281
Method getCompletePath(String relativeTo, String path) in SpringResourceAccessor class trying to remove file name from relativeTo method argument. In the case of relativeTo is a file in the root of classpath and doesn't have a "/" prefix, the regex in replace() method doesn't match the file name.

Changed regex makes the "/" symbol at the start of the string optional. It helps to remove the file name from relativeTo if it's in the root of the classpath and doesn't have a "/" prefix.

[msavy]

Has this fix held up well for you @danilmalkin ? This issue has been plaguing us in https://www.github.com/apiman/apiman

[danilmalkin]

Has this fix held up well for you @danilmalkin ? This issue has been plaguing us in apiman/apiman

Hi @msavy, yes. I've extended SpringLiquibase and SpringResourceAccessor. Now we use a custom SpringResourceAccessor with a fix from this PR.

[msavy]

Has this fix held up well for you @danilmalkin ? This issue has been plaguing us in apiman/apiman

Hi @msavy, yes. I've extended SpringLiquibase and SpringResourceAccessor. Now we use a custom SpringResourceAccessor with a fix from this PR.

Brilliant, thanks. I have a workaround/hack for now, but if they don't release this at some point soon we'll figure out a way to integrate your fixes.

By the looks of it, the tests for your change pass; I think it's just because nobody has approved your PRs tests to run that it shows as red.

[nvoxland]

Code review and test results:

Things to be aware of:

• Changes make sense to me
• We are working on a larger refactoring effort in Created new liquibase.resource.Resource interface #3064 but I think this will merge OK into there once it is done
• Only impacts Spring
• Adds automated tests

Things to worry about:

• Nothing

[github-actions]

Unit Test Results

  4 620 files  ±  0    4 620 suites  ±0   33m 22s ⏱️ - 4m 18s
  4 617 tests +  2    4 402 ✔️ +  6     215 💤  - 4  0 ❌ ±0 
54 576 runs  +24  49 556 ✔️ +28  5 020 💤  - 4  0 ❌ ±0 

Results for commit ae72ae9. ± Comparison against base commit cd2d6b0.

[msavy]

Thanks again @danilmalkin, and thanks @nvoxland for reviewing and getting that onto master. It's much appreciated.

[XDelphiGrl]

• Fix addresses a bug in stripping file names from classpath root when there is not a leading /.
• Fix limited to Spring.
• New integration tests added.
• No additional testing required.

APPROVED