-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-3202] Fix NUMBER not compatible with H2 #3098
Conversation
Code review and test results: Things to be aware of:
Things to worry about:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- PR fixes a long-standing H2 bug where explicitly defined 'numeric' datatype in changesets was replaced with 'number', which is unsupported on H2.
- An example of a changeset that was generating invalid SQL and now produces valid SQL containing
NUMERIC
is:
- An example of a changeset that was generating invalid SQL and now produces valid SQL containing
- changeSet:
changes:
- addColumn:
tableName: talent
columns:
- column:
name: rate
type: numeric(20, 2)
- New unit tests added for H2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigated test-harness build failure. It is failing due to this branch being outdated, bringing latest master changes should fix the issue. Or this failure can be ignored as we already know the reason.
I'll take care of test-harness part after that
Impact
Description
Fixes NUMBER not compatible with H2 in PostreSql compatibility mode (or suggested for h2 in general).
Full description is here - https://liquibase.jira.com/browse/CORE-3202
As H2 supports numeric, we can use it as a default type as for others DBs