-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use configuration to get 'altTablespace', 'altSchema' and 'altCatalog… #3124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and test results:
Things to be aware of:
- Changes how we get schema/catalog settings in our integration tests
- Does not impact production code
Things to worry about:
- Nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR enhances tests to validate alt* properties are cleared to ensure proper cleanup of cases where Liquibase replaces schemaName with catalogName.
- See line 200 of liquibase-integration-tests/src/test/java/liquibase/dbtest/AbstractIntegrationTest.java for the full comment on these cases.
- PR also enhances test to validate the altTablespace property is applied when creating the Liquibase tracking tables.
- No additional testing required.
APPROVED
Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen. |
…' values
Impact
Description
When I use the postgres integration test with an existing database (without using Docker), I get the following error.
liquibase.exception.DatabaseException: ERROR: tablespace "liquibase2" does not exist
The "liquibase2" value was hardcoded. These constant values are removed from the code to be read from the configuration file.