Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create liquibase_autocomplete.zsh #3130

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

szandany
Copy link
Contributor

@szandany szandany commented Jul 28, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the change being made.
This is a zsh version of the autocomplete existing examples Liquibase has for bash.

Comments

This is a stand-alone script and does not affect the Liquibase core product functionality.

Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and test results:

Things to be aware of:

  • The new file makes sense, although I don't know enough zsh to know if it's right
  • It is just in the lib directory like our other autocomplete scripts, so not used without specific user actions
  • pro-tests and test-harness failures are unrelated to this change

Things to worry about:

  • Nothing

@nvoxland nvoxland added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions autocandidate and removed Autocomplete labels Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   34m 51s ⏱️ - 1m 28s
  4 606 tests ±0    4 391 ✔️ ±0     215 💤 ±0  0 ±0 
54 444 runs  ±0  49 424 ✔️ ±0  5 020 💤 ±0  0 ±0 

Results for commit 92fc1d2. ± Comparison against base commit 6ad7472.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .zsh allows for auto-completion of Liquibase commands in the Z shell, which is the default shell in Mac OS beginning with the Catalina release.

  • No additional testing required.

APPROVED

@nvoxland nvoxland merged commit 6c6bb0f into liquibase:master Sep 19, 2022
@kataggart kataggart added this to the NEXT milestone Sep 20, 2022
@tabbyf00
Copy link

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.

@szandany szandany deleted the patch-1 branch October 21, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocandidate SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2022-34 TypeEnhancement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants