Fix an error which can occur if getAutoCommit is called on a closed connection

[gpsfl]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)

Description

Some Connection implementations (e.g. Tomcat Connection Pool) don't allow calls to getAutoCommit after the connection is closed. This can cause errors if a JdbcConnection is closed more than once.

[github-actions]

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   31m 33s ⏱️ - 5m 54s
  4 617 tests ±0    4 398 ✔️ ±0     219 💤 ±0  0 ❌ ±0 
54 576 runs  ±0  49 552 ✔️ ±0  5 024 💤 ±0  0 ❌ ±0 

Results for commit 8f0bcef. ± Comparison against base commit e742a88.

♻️ This comment has been updated with latest results.

[nvoxland]

Code review and test results:

Things to be aware of:

• Changes make sense
• Code is not hit in our code, only in external integrations

Things to worry about:

• Nothing

[XDelphiGrl]

Fix modifies JdbcConnection.rollback( ) logic to check if a connection is closed prior to checking for the autocommit state of the connection.

• This prevents errors due to calling getAutoCommit on a closed connection.
  • Tomcat Connection Pool is an example of a JDBC connection type that disallows calling getAutoCommit on a closed connection.

APPROVED

[tabbyf00]

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.