-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix order of enum values on MySQL 8 #3150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kataggart
added
DBMySQL
autocandidate
complexityLocal
TypeBug
criticalityBuilder
criticalityBlocker
Severity3
and removed
criticalityBuilder
labels
Aug 5, 2022
nvoxland
added
the
SafeToBuild
Indicates that a particular PR contains changes which are safe to build using GitHub actions
label
Aug 30, 2022
nvoxland
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and test results:
Things to be aware of:
- Code change makes sense
- There is not a great way currently to explicit test for enum ordering automatically, but existing tests would fail if the SQL is invalid
Things to worry about:
- Nothing
XDelphiGrl
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- PR enforces chronological order of enums during column snapshot generation by including an ORDER BY clause to the generated SQL.
- Fix addresses an issue specific to MySQL 8.
- No additional testing required.
APPROVED
suryaaki2
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autocandidate
complexityLocal
criticalityBlocker
DBMySQL
SafeToBuild
Indicates that a particular PR contains changes which are safe to build using GitHub actions
Severity3
sprint2022-32
TypeBug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Fixes #3147.
On MySQL 5.7.12 enums values are retrieved in the correct order.
On MySQL 8.0.28 enums values are retrieved in this order: 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 20, 19, 18, 17...
This fix adds an
order by
so enums are explicitly retrieved in the correct order.