Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed invalid warning in Maven #3189

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

nvoxland
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

When using maven, if you did not specify an outputFileEncoding setting, it gave a warning about the encoding being system dependent. That is not the case, it defaults to UTF-8 so I removed the warning. We used to fall back to the system encoding instead of UTF-8, but changed that quite a while ago (maybe 4.6?)

I also cleaned up the code slightly so that there is consistent creation of the stream regardless of how the encoding was determined.

Things to be aware of

  • Only impacts maven

Things to worry about

  • Nothing

@github-actions
Copy link

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   37m 56s ⏱️ + 1m 37s
  4 615 tests ±0    4 400 ✔️ ±0     215 💤 ±0  0 ±0 
54 552 runs  ±0  49 532 ✔️ ±0  5 020 💤 ±0  0 ±0 

Results for commit 0d45c7f. ± Comparison against base commit 19a15f5.

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix removes a misleading warning output from Liquibase Maven output.
    • If an encoding is set, Liquibase uses that.
    • If an encoding is not set, Liquibase defaults to UTF8.
  • No additional testing required.

APPROVED

Copy link
Contributor Author

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(invalid comment removed)

@nvoxland nvoxland merged commit 9a5b011 into master Aug 31, 2022
@nvoxland nvoxland deleted the remove-invalid-outputfile-warning branch August 31, 2022 17:10
@kataggart kataggart added this to the NEXT milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants