Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
When using maven, if you did not specify an outputFileEncoding setting, it gave a warning about the encoding being system dependent. That is not the case, it defaults to UTF-8 so I removed the warning. We used to fall back to the system encoding instead of UTF-8, but changed that quite a while ago (maybe 4.6?)
I also cleaned up the code slightly so that there is consistent creation of the stream regardless of how the encoding was determined.
Things to be aware of
Things to worry about