Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schemas and includeSchema parameters to maven generateChangeLog #3210

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

MalloD12
Copy link
Contributor

@MalloD12 MalloD12 commented Aug 26, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

schemas and includeSchema parameters have been added to LiquibaseGenerateChangeLogMojo class to let liquibase know which schemas needs to consider at the time of generating a change log, as well as whether to include schema names on it.

Fixes #3174

Things to be aware of

  • Nothing

Things to worry about

  • Nothing

Additional Context

N/A

@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   35m 20s ⏱️ - 2m 20s
  4 615 tests ±0    4 396 ✔️ ±0     219 💤 ±0  0 ±0 
54 552 runs  ±0  49 528 ✔️ ±0  5 024 💤 ±0  0 ±0 

Results for commit df2f0fe. ± Comparison against base commit cd2d6b0.

♻️ This comment has been updated with latest results.

@nvoxland
Copy link
Contributor

Code review and test results:

Things to be aware of:

  • Code changes are what I'd expect
  • The maven diff (also does diffChangeLog) code already had the schemas attribute in it, so no need to update that

Things to worry about:

  • Nothing

@nvoxland nvoxland changed the title Implement support to consider schemas and includeSchema parameters (#3174) Add schemas and includeSchema parameters to maven generateChangeLog Aug 29, 2022
@FBurguer
Copy link

FBurguer commented Sep 5, 2022

For this PR, I made the next few tests:

  • includeSchema with true value should include schemaName attribute for each object: PASS

  • includeSchema with true false should NOT include schemaName attribute for any object: PASS

  • Not using includeSchema should have the same behavior as setting includeSchema on false: PASS

  • schema includes all the objects from the specified schemas: PASS

  • Not using schema parameter just sets the schema parameter as default schema (including schema parameter without any specified schema has the same behavior): PASS

This was tested with all 4 changelogs formats (xml, sql, json and yml)

Test Environment:
Java 8
Windows 10
Postgresql 13 container

@nvoxland nvoxland merged commit 4c08102 into master Sep 6, 2022
@nvoxland nvoxland deleted the mvn-plugin-fix-issue-3174 branch September 6, 2022 14:45
@kataggart kataggart added this to the NEXT milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Liquibase Maven plugin doesn't support --schemas option
6 participants