Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing generator for parameterized SQL statements #3225

Merged

Conversation

fbiville
Copy link
Contributor

This prevents RawParameterizedSqlStatement to be processed during
dry-run

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

I started replacing most string-interpolated raw SQL statements with proper liquibase.statement.core.RawParameterizedSqlStatement instances in the Neo4j extension (see PR).

However, the dry-run (updateSQL) failed executing because there was no generator for these.

This should have no impact at all, since I believe only the Neo4j extension is currently using RawParameterizedSqlStatement.

There is no urgency as I already implemented the missing generator in the extension itself.
I'll remove it from the extension whenever that pull request is merged and its changes are released.

This prevents RawParameterizedSqlStatement to be processed during
dry-run
Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and test results:

Things to be aware of:

  • Changes make sense to me
  • Not code used by us, only by extensions at this point

Things to worry about:

  • Nothing

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR introduces a new class, RawParameterizedSqlGenerator which implements update-sql for parameterized SQL.

  • Class currently used by 3rd Party Extension (Neo4j).
  • No usage of class in Liquibase core code.
  • No additional testing necessary.

APPROVED

@nvoxland nvoxland merged commit d31a710 into liquibase:master Sep 26, 2022
@nvoxland nvoxland added this to the 1NEXT milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants