Postgresql: Fix for case when current search_path is an empty string

[gadget]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

In certain cases the search path in a postgres database can be empty (not null, but an empty string). For us it happens when running postgres with testcontainers for IT tests, probably on rollbacks (as you call initializeDatabase for every rollback to reset default schema). In case searchPath is empty we should not try and process it, just re-set the default schema.

[nvoxland]

Code review and test results:

Things to be aware of:

• Changes make sense to me, it's keeping an invalid search_path with a trailing , from being made
• Probably not a code path that gets hit in our code's setup, and not something that is easy to write a test for at this point. But existing tests should catch anything surprising it breaks.
• Functional test failures are unrelated to this change

Things to worry about:

• Nothing

[github-actions]

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   37m 0s ⏱️ + 1m 10s
  4 619 tests ±0    4 404 ✔️ ±0     215 💤 ±0  0 ❌ ±0 
54 600 runs  ±0  49 580 ✔️ ±0  5 020 💤 ±0  0 ❌ ±0 

Results for commit ff9225b. ± Comparison against base commit 98e7a36.

[XDelphiGrl]

PR fixes a bug to prevent empty Postgres SEARCH_PATH values from being set. In the case where the SEARCH_PATH is empty, Liquibase will use the default schema as the SEARCH_PATH.

APPROVED

Note: Functional test failures on DB2 LUW and MariaDB are due to test validations out of sync with current Liquibase master; this is not related to this PR (which only impacts Postgres, which is passing).

[tabbyf00]

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.