Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the smallserial issue not being parsed as a SmallInt type for Postgres #3234

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

MalloD12
Copy link
Contributor

@MalloD12 MalloD12 commented Sep 1, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

"smallserial" alias has been added as part of the "SmallInt" type to allow liquibase to generate the expected SQL statements form a given changelog.

Fixes #1946

Things to be aware of

  • Code changes are what I'd expect for postgres handling serial types

Things to worry about

  • Nothing

Additional Context

  • Nothing

…ype. Also updated CreateTableChangeTest to validate the expected sql is generated for smallserial type.
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   33m 52s ⏱️ - 3m 23s
  4 619 tests ±0    4 400 ✔️  - 4     219 💤 +4  0 ±0 
54 600 runs  ±0  49 576 ✔️  - 4  5 024 💤 +4  0 ±0 

Results for commit d65c825. ± Comparison against base commit 98e7a36.

@nvoxland
Copy link
Contributor

nvoxland commented Sep 2, 2022

Code review and test results:

Things to be aware of:

  • The changes all look good, nice job
  • Only impacts smallserial handling on postgresql

Things to worry about:

  • Nothing

@XDelphiGrl XDelphiGrl changed the title Fix the smallserial issue not being parsed as a SmallInt type Fix the smallserial issue not being parsed as a SmallInt type for Postgres Sep 20, 2022
Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix addresses bug where the Postgres smallint data type was mishandled during SQL generation. The fix adds a smallint alias for smallserial and sets autoincrement to true for smallserial.

  • New unit test added.
  • No additional testing required.

APPROVED

@nvoxland nvoxland merged commit ede8102 into master Sep 20, 2022
@kataggart kataggart added this to the NEXT milestone Sep 21, 2022
@filipelautert filipelautert deleted the fix-issue-1946 branch April 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Postgresql smallserial is not handled like serial and bigserial
4 participants