-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generateChangeLog and diffChangeLog logic to avoid including default schema name when it should not #3246
Conversation
…chema name when includeSchame flag is set to false
cf0ad26
to
7cbf799
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and test results:
Things to be aware of:
- The changes make sense to me
- New tests (and changed behavior of existing setup) is shown in liquibase/liquibase-pro-tests#447 and those look correct
- Only impacts generateChangeLog with formatted sql
The generated sql will be different for people that are used to having the schema included. But they can use the existing flags to (now correctly) configure that behavior. It's good the formatted sql output now matches the default values.
Things to worry about:
- Nothing
In reading the linked issue, it looks like the problematic command included both
Thanks! |
Hi @XDelphiGrl, sorry for the late reply but I just saw these questions. Below my answers:
Thanks for your valuable questions, and again my apologises for my late response. Daniel. |
@MalloD12, no need to apologize! We are all very busy. Thank you for answering my questions, I appreciate the extra clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix prevents schema names from being included in generated changelogs when include-schema is false.
- Functional tests were updated to match the output from the fixed Core code.
- No additional testing required.
APPROVED
Impact
Description
Fix generateChangeLog and DiffChangeLog logic to avoid including default schema name when
includeSchema=false
.FIXES #2776
Things to be aware of
includeSchema
flag parameter.Things to worry about
Additional Context