-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove snowflake unsupported logging from snapshot command (DAT-11291) #3277
Conversation
|
||
public static void logUnsupportedDatabase(Database database, Class callingClass) { | ||
if (LicenseServiceUtils.isProLicenseValid()) { | ||
if (!(database instanceof MSSQLDatabase | ||
|| database instanceof OracleDatabase | ||
|| database instanceof MySQLDatabase | ||
|| database instanceof DB2Database | ||
|| database instanceof PostgresDatabase)) { | ||
|| database instanceof PostgresDatabase | ||
|| database.getShortName().equalsIgnoreCase("snowflake"))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to do this hacky because adding a dependency on the snowflake module would cause a circular dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Until that module is fully integrated into core we've got to use this hack. I talked it through with @nvoxland but I should probably also add a TODO. I'll do that now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the easiest way to make the change. We'd like something different, but it will take some thought on how to organize the code
Impact
Description
Removes message
INFO This command might not yet capture Liquibase Pro additional object types on snowflake
when running snapshot against snowflake.Things to be aware of
Removed duplicate code from SnapshotCommandStep.
Things to worry about
N/A
Additional Context
N/A