Fixed input string handling in CompareControl constructor #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelautert
changed the title
nvoxland
approved these changes
Oct 12, 2022
nvoxland
changed the title
suryaaki2
approved these changes
Nov 3, 2022
XDelphiGrl
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
This PR addresses a bug in the logic used to split catalog.schema based on the . character. Without this fix, Liquibase interpreted aaa.bbb as having a catalogName of empty string and a schema name of aa.bbb. With the fix, Liquibase correctly identifies the catalogName as aaa and the schemaName as bbb.
- New unit test added.
- No additional testing required.
APPROVED
nvoxland
deleted the
3204-comparecontrol-constructor-handles-input-strings-incorrectly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Incorrect regex expression "." in call to 'split()' at CompareControl constructor was causing the strings to being wrongly slit.
As this code is not used within liquibase-core, an unit test was created.
Fixes #3204
Things to be aware of
Things to worry about
Additional Context