Improved readability in the createCDILiquibaseConfig method. #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@musttafayildirim Can you please provide some of the requested details in the Description? I understand this isn't a major change so some of the questions might not apply, but more context helps us with review, release notes, etc. Thanks much! |
filipelautert
added
SafeToBuild
filipelautert
added
SafeToBuild
filipelautert
added
SafeToBuild
XDelphiGrl
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
This PR improves the SchemesCDIConfigBuilder method to improve readability. This change introduces an end variable to indicate the time when a scan completes, allowing developers to add a watch as they step through the code. Prior to this change, the end was buried in a log.info statement.
- Test harness failure unrelated to this change.
- No additional testing required.
APPROVED
nvoxland
approved these changes
Nov 4, 2022
filipelautert
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Adds new line breaks to a code that seems packed up. No functionality change, just code readability.
Things to be aware of
None
Things to worry about
None
Additional Context
None