Allows createSequence field "dataType" to be use with DB2 as the database supports it. #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base supports it.
filipelautert
force-pushed
the
2254-support-datatype-for-createsequence-on-db2luw
branch
from
153ce03
to
45501b0
Compare
nvoxland
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Code review:
Things to be aware of:
- Apparently the datatype syntax was valid for db2, we just hadn't tested it
- Added integration test to verify it for db2 plus all database types that support it
- Only impacts db2 people using dataType on createSequence
Things to worry about:
- Nothing
|
The default database for branch runs of the functional tests is against Postgres. I'm running a build that includes DB2. |
suryaaki2
approved these changes
Nov 3, 2022
XDelphiGrl
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
This PR extends Liquibase to support DB2 sequences defined with a datatype. For example, Liquibase will now snapshot (and generate-changelog/diff-changelog) a DB2 sequence such as:
CREATE SEQUENCE ORG_SEQ AS BIGINT START WITH 1 INCREMENT BY 1
- New integration test added (where the dataType specified is 'INT').
- Functional tests for DB2 passing on this branch.
- No additional testing required.
APPROVED
nvoxland
deleted the
2254-support-datatype-for-createsequence-on-db2luw
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
As per documentation DB2 documentation (https://www.ibm.com/docs/en/db2/9.7?topic=statements-create-sequence) , dataType parameter is supported by create sequence on DB2.
This PR just removes DB2 from the "blacklist" of "dataType" and adds an integration test to validate that.