Fixes snapshot of case-sensitive views #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated when it is created with objectQuotingStrategy="QUOTE_ALL_OBJECTS" and evaluated without
nvoxland
changed the title
nvoxland
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Code review and test results:
Things to be aware of:
- I was wondering if the ViewSnapshotGenerator was the place to put the change, since there are times users specify the view name and may be specifying with the wrong case. But the only spot that does that is the viewExists precondition and that code already corrects the case before passing it to this function. So the change is good and is best-handling it at the lowest spot.
- Test exposes a separate potential issue in that generated changests don't include any object quoting. Unsure if that's a feature or a bug, and nobody has ever asked about it that I remember so I won't worry about it now.
- Includes new integration test in h2 that tests this specifically for case sensitivity. It uses "tableExists" since the issue used that, but the root cause is view snapshot since h2 ends up snapshotting views as part of table snapshot.
Things to worry about:
- Nothing, my one worry was handled
XDelphiGrl
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
This PR fixes an H2 bug caused by differences in the Liquibase setting for OBJECT_QUOTING_STRATEGY during object creation and the default OBJECT_QUOTING_STRATEGY when preconditions are evaluated.
- New integration test added.
- Functional test failure unrelated to fix.
- No additional testing required.
APPROVED
suryaaki2
approved these changes
Nov 4, 2022
filipelautert
deleted the
2659-precondition-tableexists-crashes-h2-ok
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
When a view is created using objectQuotingStrategy="QUOTE_ALL_OBJECTS" , the name is saved as defined (ie: "MyView" ) - otherwise it is all upcase (MYVIEW) . As the default strategy for h2 is LEGACY, it fails on subsequent changesets unless QUOTE_ALL_OBJECTS is specified (tested on H2 and postgres: H2 failed, postgresql not).
It fails using the "update" command - if we execute the command "snapshot" , the strategy is already set by default to QUOTE_ALL_OBJECTS so it works.
This PR changes the strategy to QUOTE_ALL_OBJECTS, snapshots the views and then sets it back to what it was before (as it is done in some others parts of the code).
Things to be aware of
Things to worry about
Additional Context