Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getResourceAccessor logic to avoid setting changeLogDirectory when searchPath has already set #3347

Merged
merged 6 commits into from
Nov 8, 2022

Conversation

MalloD12
Copy link
Contributor

@MalloD12 MalloD12 commented Oct 7, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #3282

Things to be aware of

  • Maven was conflicting to find changelog file in two different paths, so this fix avoid setting a new location if there is one already defined.
  • Only impacts Maven.

Things to worry about

  • Nothing

Additional Context

  • Nothing

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Unit Test Results

  4 680 files  +12    4 680 suites  +12   36m 15s ⏱️ -3s
  4 643 tests +  2    4 417 ✔️ +  2     226 💤 ±0  0 ±0 
54 720 runs  +24  49 657 ✔️ +24  5 063 💤 ±0  0 ±0 

Results for commit 64dedfe. ± Comparison against base commit 00ee3f9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses a bug where Liquibase Maven disregarded the changeLogDirectory property, resulting in the unexpected location of two changelog files (one in src, the other in target). Now Liquibase will look for a changelog only within the specified changeLogDirectory.

  • New unit tests added.
  • No additional testing required.

APPROVED

@nvoxland nvoxland merged commit b198569 into master Nov 8, 2022
@nvoxland nvoxland deleted the fix-issue-3282 branch November 8, 2022 07:06
@kevin-atx kevin-atx added this to the 1NEXT milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Maven plugin ignores changeLogDirectory, finds two changelog files
5 participants