Fix create index on Postgresql and MSSQL using wrong column names when generating a changelog #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ILTER_CONDITION field when snapshoting indexes (as both support partial indexes, FILTER_CONDITION brings the filter and not the function value)
…ith-cli-generate-changelog-command
…ith-cli-generate-changelog-command
…ith-cli-generate-changelog-command
XDelphiGrl
reviewed
Nov 3, 2022
| break; | ||
| } | ||
| } | ||
| Assert.assertTrue("There should be a sequence column starting with function \"" + function + "\"", found); |
There was a problem hiding this comment.
Because "sequence" is a datatype, and we are not checking anything related to sequences, this assertion would be more clear if it was changed to something like "There should be a computed column ...".
XDelphiGrl
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
This PR fixes a bug that caused indexes created with WHERE clauses to use the WHERE clause instead of the column name in a generated createIndex changeset. The bug, and fix, are specific to Postgres and SQL Server.
- New integration test added.
- Internal functional tests to change test to match new/correct behavior.
- No additional testing required.
APPROVED
Note: The wording in the integration test assertion could be updated, but I will not block the PR from approval based on that. If you can make the change before merging, @filipelautert, that would be very helpful.
nvoxland
deleted the
2953-conditional-index-wrongly-generated-with-cli-generate-changelog-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Postgresql and MSSQL server support conditional indexes (a WHERE when creating the index). When a conditional index is exported by generate-changelog, liquibase is replacing the columns by the where condition. This fix makes sure that the columns are corrected exported.
As discussed with Nathan, implementing the "where" condition would be too specific for those databases and is currently not supported by Liquibase, thus it's being ignored.
This fix makes sure that Postgresql and MSSQL use the column name instead of FILTER_CONDITION field when snapshoting indexes (as both support partial indexes, FILTER_CONDITION brings the filter and not the function value)
Things to be aware of
Things to worry about
Additional Context