Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify if statements to a single assignment. Avoid extra works. #3375

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Simplify if statements to a single assignment. Avoid extra works. #3375

merged 2 commits into from
Nov 28, 2022

Conversation

arturobernalg
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • [X ] Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Simplify if statements to a single assignment. Avoid extra works.
N/A

@nvoxland
Copy link
Contributor

nvoxland commented Nov 7, 2022

Pre-Review Notes

Like the description says, it simplifies some if statements to make the code a bit cleaner

Questions I have:

  • None

Potential risks:

  • None

What could make the full review difficult:

  • Nothing

@nvoxland nvoxland removed their assignment Nov 7, 2022
@MalloD12 MalloD12 self-assigned this Nov 22, 2022
MalloD12
MalloD12 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Review and testing results:

Code clean up changes looks good to me. Build ran successfully.

Things to be aware of:

  • None

Things to worry about:

  • None

@MalloD12 MalloD12 added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2022-38 and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited

Unit Test Results

  4 776 files  ±  0    4 776 suites  ±0   35m 28s ⏱️ + 4m 9s
  4 735 tests +18    4 502 ✔️ +21     233 💤  - 3  0 ❌ ±0 
55 836 runs  +12  50 508 ✔️ +17  5 328 💤  - 5  0 ❌ ±0 

Results for commit 972f50b. ± Comparison against base commit 729d8b0.

♻️ This comment has been updated with latest results.

@filipelautert filipelautert merged commit 59db54a into liquibase:master Nov 28, 2022
@filipelautert filipelautert added this to the 4.18.0 milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipelautert filipelautert filipelautert approved these changes

@MalloD12 MalloD12 MalloD12 approved these changes

@nvoxland nvoxland Awaiting requested review from nvoxland

Assignees

@MalloD12 MalloD12

Labels
autocandidate SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2022-38 TypeRefactor
Projects
Liquibase Open Source
Archived in project
Milestone
4.18.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@arturobernalg @nvoxland @filipelautert @MalloD12 @kevin-atx @kataggart @tabbyf00