Fix CORE-2178 Use correct database collation #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String collation = ExecutorService.getInstance().getExecutor(this).queryForObject(new RawSqlStatement("SELECT CONVERT(varchar(100), SERVERPROPERTY('COLLATION'))"), String.class); | ||
| caseSensitive = ! collation.contains("_CI_"); | ||
| String catalog = getConnection().getCatalog(); | ||
| String sql = String.format("SELECT CONVERT(varchar(100), DATABASEPROPERTYEX('%s', 'COLLATION'))", catalog); |
There was a problem hiding this comment.
I don't think there is an SQL injection problem here, but I'm not familiar enough with SQL Server to know for sure.
There was a problem hiding this comment.
Since the goal of Liquibase is to run arbitrary SQL I tend to not worry too much about sql injection problems so I think it is fine.
nvoxland
added a commit
that referenced
this pull request
Jan 5, 2015
…rver Fix CORE-2178 Use correct database collation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CORE-2178: https://liquibase.jira.com/browse/CORE-2178
MSSQLDatabase.isCaseSensitive() uses the system collation rather than the database collation to determine whether or not the database is case-sensitive. That is fixed by checking DATABASEPROPERTYEX(, 'collation').
Also, MSSQLDatabase.getdbcSchemaName() always converts to lower case. That causes a false negative on a case-sensitive database when checking to see if the lock table exists.
I am not nearly familiar enough to understand the full impact of this change, but it does seem to fix the problem we are having on SQL Server 2012.