Implement tagExists Maven command (Fix issue 1063)

[rozenshteyn]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Implement tagExists Maven command. Fixes #1063.

Modeled after the existing LiqubaseTag mojo class.
Users will be able to run the command: mvn liquibase:tagExists -Dliquibase.tag=myTag to check for existence of the specified tag in the configured database.

Things to be aware of

• None at this time

Things to worry about

• I am not sure if anything else (other than implementing the mojo class) needs to be done in order for the functionality to show up in the Liquibase Maven plugin.

Additional Context

None at this time.

[github-actions]

Unit Test Results

  4 752 files  +12    4 752 suites  +12   36m 2s ⏱️ -7s
  4 695 tests +  2    4 459 ✔️ +  2     236 💤 ±0  0 ❌ ±0 
55 560 runs  +24  50 252 ✔️ +24  5 308 💤 ±0  0 ❌ ±0 

Results for commit 25d3c6a. ± Comparison against base commit 0aa4be9.

♻️ This comment has been updated with latest results.

[MalloD12]

Approved!

Review and testing results:

Overall this PR looks ok to me. Few small changes has been made and are detailed below:

• Added goal annotation to TagExists Mojo class.
• Updated testTag unit tests to validate tag is set and properly set to the mojo under test.
• Update existent testTag integration test to also perform a tagExists validation. I decided to update the existing test and not added a new one, because the test would be pretty much the same and I thought it is worth using the same setup and not duplicate code for testing almost the same scenario.

Things to be aware of:

• Nothing

Things to worry about:

• Nothing. Only applicable to Maven plugin so no further impact.

Additional comment:
Although autocandidate tag has been added. I think might be worth performing a round of exploratory testing around maven plugin. We have unit/integration tests to validate commands are successfully executed, but at this point nothing maven specific.

[XDelphiGrl]

I appreciate the comment explaining why this particular changelog is used in the test. Thank you!

[XDelphiGrl]

@MalloD12, hi!

Additional comment: Although autocandidate tag has been added. I think might be worth performing a round of exploratory testing around maven plugin. We have unit/integration tests to validate commands are successfully executed, but at this point nothing maven specific.

We do have functional automated tests that exercise Maven goals. We should add a new one for this feature. I will create an internal Jira ticket to make sure we do that. I do not believe this particular PR requires any additional manual testing.

[MalloD12]

We do have functional automated tests that exercise Maven goals. We should add a new one for this feature. I will create an internal Jira ticket to make sure we do that. I do not believe this particular PR requires any additional manual testing.

Oh nice, I might not see them yet or might forget about those. Where are they? I

[XDelphiGrl]

This PR extends the Liquibase Maven plugin to support the tagExists goal.

• Functional tests passing with a manual rerun here: https://github.com/liquibase/liquibase-pro-tests/actions/runs/3473764788
  • An internal Liquibase functional test ticket was created to add a tagExists test. (DAT-12404)
• No additional testing necessary.

APPROVED

[filipelautert]

All fine, new maven command.