-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gmavenplus-plugin from 1.13.1 to 2.1.0 #3391
Bump gmavenplus-plugin from 1.13.1 to 2.1.0 #3391
Conversation
Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.13.1 to 2.1.0. - [Release notes](https://github.com/groovy/GMavenPlus/releases) - [Commits](groovy/GMavenPlus@1.13.1...2.1.0) --- updated-dependencies: - dependency-name: org.codehaus.gmavenplus:gmavenplus-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Pre-Review Notes: This is what drives the spock/groovy tests, so I wondered if the major version upgrade would not be compatible with teh older version of groovy and/or spock and/or java we have. But the builds passed so must be. Questions I have:
Potential risks:
What could make the review difficult:
|
…mavenplus-plugin-2.1.0
…mavenplus-plugin-2.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Bump version seems to be ok, as build run successfully with all tests passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core is building fine. I wonder if it afect pro build?
Bumps gmavenplus-plugin from 1.13.1 to 2.1.0.
Release notes
Sourced from gmavenplus-plugin's releases.
Commits
c56807e
[maven-release-plugin] prepare release 2.1.03d51f8f
Fix typo using comma instead of period3c8024b
Merge pull request #232 from groovy/support_jdk2070cc954
Support Java 20 bytecode5fabc17
Document requirements for Java 198a195c3
Update test Groovy version to 4.0.696a4a9c
Add more test versions83ab759
Merge pull request #231 from groovy/230e570b38
Recognize target bytecode 19 (closes #230)dbcd58e
Upgrade Maven to 3.8.6Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)