Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gmavenplus-plugin from 1.13.1 to 2.1.0 #3391

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2022

Bumps gmavenplus-plugin from 1.13.1 to 2.1.0.

Release notes

Sourced from gmavenplus-plugin's releases.

2.1.0

Bugs

None.

Enhancements

  • #230 Recognize JDK 19 as a valid target bytecode.
  • #232 Recognize JDK 20 as a valid target bytecode.

Potentially breaking changes

None.

Notes

None.

2.0.0

Bugs

None.

Enhancements

  • #210 Improve error messages when Groovy classes can't be located (avoiding the NullPointerExceptions that were causing confusion and instead throwing our own exception).
  • #221 apache/groovy@8d19017#diff-5522480b605c81fc7dd50f58b857f5fc8802ea69229742441c6fdef328846062 caused an exception to be thrown for Groovy 4.0.0-RC-1 and newer when binding properties in a script/console/shell and bindPropertiesToSeparateVariables is false. The error logging when this happens has been improved.
  • #223 Support 5, 6, 7, 8, and 1.9 arguments to targetBytecode so that validation doesn't unexpectedly fail since it uses the maven.compiler.target property and these arguments are valid for javac.

Potentially breaking changes

This release requires Java 8 and drops support for Java 7. This was necessary to update dependencies which fix vulnerabilities. Specifically, in maven-archiver. At the time of release, the following dependencies were not compatible with Java 7

  • org.apache.commons:commons-compress
  • org.codehaus.plexus:plexus-archiver
  • org.apache.maven:maven-archiver
  • org.codehaus.plexus:plexus-io
  • org.codehaus.plexus:plexus-utils

This is not the first breaking release, but it is the first breaking release to follow the semver conventions.

Notes

None.

Commits
  • c56807e [maven-release-plugin] prepare release 2.1.0
  • 3d51f8f Fix typo using comma instead of period
  • 3c8024b Merge pull request #232 from groovy/support_jdk20
  • 70cc954 Support Java 20 bytecode
  • 5fabc17 Document requirements for Java 19
  • 8a195c3 Update test Groovy version to 4.0.6
  • 96a4a9c Add more test versions
  • 83ab759 Merge pull request #231 from groovy/230
  • e570b38 Recognize target bytecode 19 (closes #230)
  • dbcd58e Upgrade Maven to 3.8.6
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.13.1 to 2.1.0.
- [Release notes](https://github.com/groovy/GMavenPlus/releases)
- [Commits](groovy/GMavenPlus@1.13.1...2.1.0)

---
updated-dependencies:
- dependency-name: org.codehaus.gmavenplus:gmavenplus-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from nvoxland as a code owner October 21, 2022 02:40
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 21, 2022
@github-actions
Copy link

github-actions bot commented Oct 21, 2022

Unit Test Results

  4 752 files  ±0    4 752 suites  ±0   36m 53s ⏱️ + 1m 34s
  4 699 tests ±0    4 463 ✔️ ±0     236 💤 ±0  0 ±0 
55 608 runs  ±0  50 289 ✔️ ±0  5 319 💤 ±0  0 ±0 

Results for commit e0dd1fc. ± Comparison against base commit bc51733.

♻️ This comment has been updated with latest results.

@nvoxland
Copy link
Contributor

nvoxland commented Nov 4, 2022

Pre-Review Notes:

This is what drives the spock/groovy tests, so I wondered if the major version upgrade would not be compatible with teh older version of groovy and/or spock and/or java we have. But the builds passed so must be.

Questions I have:

  • None

Potential risks:

  • None

What could make the review difficult:

  • Nothing

@MalloD12 MalloD12 self-assigned this Nov 17, 2022
@MalloD12 MalloD12 self-requested a review November 17, 2022 21:28
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Bump version seems to be ok, as build run successfully with all tests passing.

Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core is building fine. I wonder if it afect pro build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code sprint2022-38
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants