Fixes generate-changelog view comments for Postgres (DAT-9410) #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generating sql for postgres views.
…ates CreateViewChange to use new view specific classes. Handles oracle and postgres view comment creation. Updates DiffChangelogTest to look for view comments.
abrackx
requested review from
StevenMassaro,
filipelautert,
MalloD12,
wwillard7800 and
suryaaki2
StevenMassaro
approved these changes
Oct 24, 2022
suryaaki2
approved these changes
Oct 24, 2022
nvoxland
approved these changes
Oct 25, 2022
filipelautert
approved these changes
Oct 25, 2022
…ewChangeGenerator due to priority duplication.
abrackx
requested review from
nvoxland,
filipelautert,
StevenMassaro and
suryaaki2
abrackx
changed the title
abrackx
changed the title
suryaaki2
approved these changes
Oct 26, 2022
filipelautert
approved these changes
Oct 27, 2022
nvoxland
approved these changes
Oct 27, 2022
1 task
1 task
This was referenced May 26, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
SetViewRemarksGenerator,SetViewRemarksStatement, updatesCreateViewChangeto use new view specific classes. Handles oracle and postgres view comment creation forgenerate-changelog. UpdatesDiffChangelogTestto look for view comments since that uses the same code path.MissingViewChangeGeneratorto iterate through columns and generate column comments.Things to be aware of
New statement available.
I tried to create a
MissingViewColumnRemarksChangeGeneratorhowever there's a problem with conflicting priorities. BothMissingViewColumnRemarksChangeGeneratorandMissingColumnChangeGeneratorneed to operate basically at the same priority (PRIORITY_DEFAULT for when a column object type is detected).Things to worry about
Now we're handling column comments in a view specific generator.
Additional Context
N/A