The onSqlOutput attribute does not work for preconditions in formatted SQL changelogs. #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryaaki2
requested changes
Nov 3, 2022
|
|
||
| PreconditionContainer pc = new PreconditionContainer(); | ||
| pc.setOnFail(StringUtil.trimToNull(parseString(onFailMatcher))); | ||
| pc.setOnError(StringUtil.trimToNull(parseString(onErrorMatcher))); | ||
| pc.setOnSqlOutput(StringUtil.trimToNull(parseString(onUpdateSqlMatcher))); | ||
| if (onSqlOutputMatcher.matches()) { |
There was a problem hiding this comment.
@dyadyushko Can you handle the condition that if changelog contains both onUpdateSql and onSqloutput in which case, we should throw an error, "Please modify the changelog to have preconditions set with either "onUpdateSql" or "onSqlOutput"?
There was a problem hiding this comment.
That's a good solution
nvoxland
approved these changes
Nov 4, 2022
suryaaki2
changed the title
suryaaki2
approved these changes
Nov 4, 2022
filipelautert
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
The attribute to control the behavior of update-sql when using preconditions is onUpdateSQL for formatted SQL changelogs. For all other changelog formats, the attribute is onSqlOutput. We should be consistent so that the same attribute works for all changelog formats. That is, users of formatted sql changelogs should be able to use onSqlOutput.
Things to be aware of
Things to worry about