Use PathHandler for writing log files, which allows using S3 and other extensions (DAT-11515) #3438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9949ca0.
Impact
Description
Create log files using the
PathHandler
interfaces. Add support for differentOpenOptions
for resources, like appending and truncating existing files.Things to be aware of
Handler
inLiquibaseCommandLine
. This is actually unnecessary as the Java log framework will handle closing it at the appropriate time. Additionally, Liquibase was closing the handler too early, which caused an exception to be thrown by the logging framework itself:java.lang.IllegalStateException: Current state = FLUSHED, new state = CODING
Things to worry about