Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ChangeExecListener properties to maven plugin (DAT-12219) #3443

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Adds ChangeExecListener properties to maven plugin (DAT-12219) #3443

merged 2 commits into from
Nov 9, 2022

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Nov 7, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Adds change exec listener and rollback on error property elements. Sets up change exec listener for mojos. Handles migration errors on updates.

Things to be aware of

N/A

Things to worry about

N/A

Additional Context

N/A

@abrackx
[DAT-12219] Adds change exec listener and rollback on error property …
3c1d4df 
…elements. Sets up change exec listener for mojos. Handles migration errors on updates.
@abrackx abrackx self-assigned this Nov 7, 2022
@abrackx abrackx marked this pull request as ready for review November 7, 2022 12:42
@github-actions
Copy link

github-actions bot commented Nov 7, 2022 •
edited

Unit Test Results

  4 740 files  ±0    4 740 suites  ±0   34m 59s ⏱️ + 1m 1s
  4 711 tests ±0    4 478 ✔️ ±0     233 💤 ±0  0 ❌ ±0 
55 548 runs  ±0  50 245 ✔️ ±0  5 303 💤 ±0  0 ❌ ±0 

Results for commit a99454f. ± Comparison against base commit 1bfeb0e.

♻️ This comment has been updated with latest results.

@abrackx
Copy link
Contributor Author

abrackx commented Nov 7, 2022 •
edited

  • Try to make this change in the Liquibase#update method.

nvoxland
nvoxland approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuck with the duplication in AbstractLiquibaseMojo until maven gets refactored to use the command framework

@suryaaki2 suryaaki2 merged commit fe07fae into master Nov 9, 2022
@suryaaki2 suryaaki2 deleted the DAT-12219 branch November 9, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@StevenMassaro StevenMassaro Awaiting requested review from StevenMassaro

@wwillard7800 wwillard7800 Awaiting requested review from wwillard7800

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees

@abrackx abrackx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abrackx @nvoxland @suryaaki2