Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes nullpointer when dealing with LiquibaseException on updates. #3447

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Fixes nullpointer when dealing with LiquibaseException on updates. #3447

merged 1 commit into from
Nov 7, 2022

Conversation

filipelautert
Copy link
Collaborator

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

If an update throws a LiquibaseException, rollbackOnError may be uninitialized and throws a NPE.

Things to be aware of

  • None

Things to worry about

  • None

Additional Context

@filipelautert filipelautert self-assigned this Nov 7, 2022
@filipelautert filipelautert changed the title Fixes nullpointer when dealing with errors. Fixes nullpointer when dealing with LiquibaseException on updates. Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Unit Test Results

  4 668 files  ±  0    4 668 suites  ±0   35m 23s ⏱️ + 1m 45s
  4 627 tests  - 18    4 398 ✔️  - 21     229 💤 +3  0 ❌ ±0 
54 732 runs   - 12  49 608 ✔️  - 17  5 124 💤 +5  0 ❌ ±0 

Results for commit 32360de. ± Comparison against base commit 0f1cb97.

@filipelautert filipelautert merged commit 1a92adb into master Nov 7, 2022
@filipelautert filipelautert deleted the fix_nullpointer_on_error_on_main branch November 7, 2022 18:05
@kevin-atx kevin-atx added this to the 1NEXT milestone Nov 9, 2022
This was referenced Mar 8, 2023
Open
Merged
Merged
This was referenced Mar 16, 2023
Closed
Open
Open
@renovate renovate bot mentioned this pull request Mar 28, 2023
Open
1 task
This was referenced Apr 15, 2023
Merged
Open
@renovate renovate bot mentioned this pull request May 25, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrackx abrackx abrackx approved these changes

@nvoxland nvoxland Awaiting requested review from nvoxland

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees

@filipelautert filipelautert

Labels
sprint2022-37 TypeBug
Projects
Liquibase Open Source
Archived in project
Milestone
4.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@filipelautert @abrackx @kevin-atx