Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAT-11899] Modifies deploy plugin and distribution management. #3457

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

jnewton03
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the change being made.

  • Introduce what was/will be done in the title
    • Titles show in release notes and search results, so make them useful
    • Use verbs at the beginning of the title, such as "fix", "implement", "improve", "update", and "add"
    • Be specific about what was fixed or changed
    • Good Example: Fix the --should-snapshot-data CLI parameter to be preserved when the --data-output-directory property is not specified in the command.
    • Bad Example: Fixed --should-snapshot-data
  • If there is an existing issue this addresses, include "Fixes #XXXX" to auto-link the issue to this PR
  • If there is NOT an existing issue, consider creating one.
    • In general, issues describe wanted change from an end-user perspective and PRs describe the technical change.
    • If this change is very small and not worth splitting off an issue, include Steps To Reproduce, Expected Behavior, and Actual Behavior sections in this PR as you would have in the issue.
  • Describe what users need and how the fix will affect them
  • Describe how the code change addresses the problem
  • Ensure private information is redacted.

Things to be aware of

  • Describe the technical choices you made
  • Describe impacts on the codebase

Things to worry about

  • List any questions or concerns you have with the change
  • List unknowns you have

Additional Context

Add any other context about the problem here.

@jnewton03 jnewton03 merged commit deb5763 into DAT-11899 Nov 9, 2022
@jnewton03 jnewton03 deleted the DAT-11899-ab branch November 17, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants