Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds error handling for updateCount (DAT-11950) #3463

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Adds error handling for updateCount (DAT-11950) #3463

merged 2 commits into from
Nov 22, 2022

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Nov 14, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Adds error handling for updateCount.

Things to be aware of

N/A

Things to worry about

N/A

Additional Context

N/A

@abrackx abrackx self-assigned this Nov 14, 2022
@github-actions
Copy link

github-actions bot commented Nov 14, 2022 •
edited

Unit Test Results

  4 740 files  ±0    4 740 suites  ±0   36m 34s ⏱️ +58s
  4 714 tests ±0    4 481 ✔️ ±0     233 💤 ±0  0 ❌ ±0 
55 584 runs  ±0  50 281 ✔️ ±0  5 303 💤 ±0  0 ❌ ±0 

Results for commit 319f3ef. ± Comparison against base commit 2d333a2.

♻️ This comment has been updated with latest results.

@abrackx abrackx marked this pull request as ready for review November 14, 2022 13:22
filipelautert
filipelautert approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR added generic method allowing reuse of error handling logic.

@suryaaki2 suryaaki2 merged commit bba8e17 into master Nov 22, 2022
@suryaaki2 suryaaki2 deleted the DAT-11950 branch November 22, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@filipelautert filipelautert filipelautert approved these changes

@StevenMassaro StevenMassaro StevenMassaro approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

@MalloD12 MalloD12 Awaiting requested review from MalloD12

@wwillard7800 wwillard7800 Awaiting requested review from wwillard7800

Assignees

@abrackx abrackx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abrackx @nvoxland @filipelautert @StevenMassaro @suryaaki2