Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes behaviour of includeAll by keeping the trailing slash on the path #3506

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

filipelautert
Copy link
Collaborator

@filipelautert filipelautert commented Nov 24, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

PR #3355 aimed to fix issues related to "./" and "../" , but by using Paths.get it is also removing trailing slashs. The changed method has logic to append the trailing slash, but it is located above the new code - so it baceme useless. This PR moves the code that fixes the path to be executed after Paths.get.

Things to be aware of

Things to worry about

  • None

Additional Context

  • Issue raised by S3 extension tests.

…th (Paths.get added on #3355 to normalize Strings removes it)
@github-actions
Copy link

Unit Test Results

  4 776 files  ±  0    4 776 suites  ±0   32m 47s ⏱️ + 1m 28s
  4 735 tests +18    4 502 ✔️ +21     233 💤  - 3  0 ±0 
55 836 runs  +12  50 508 ✔️ +17  5 328 💤  - 5  0 ±0 

Results for commit 13b8247. ± Comparison against base commit 729d8b0.

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR addresses a regression introduced while fixing the path shown in some output messages and the value stored in DATABASECHANGELOG tracking table when include or includeAll changesets specify relativeToChangelog=true. The original fix was too broad, and stripped trailing as well as leading slashes; only leading should be removed. This fix restores the correct behavior of keeping trailing slashes.

  • Automated functional and test harness executions passing.
  • S3 extension test that exposed the bug is fixed by this PR.
  • New unit test added.
  • No additional testing required.

APPROVED

@filipelautert filipelautert merged commit 68efcff into master Nov 28, 2022
@filipelautert filipelautert deleted the DAT-12499 branch November 28, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants