Fix getSerializableFieldValue when dealing with rollback object #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the fix @MalloD12 ! Could you also add a test to validate that the xml format still working fine too?
Sure, I'll do that @filipelautert. Thanks, |
- Add unit tests.
… into fix-issue-2084
filipelautert
approved these changes
Dec 20, 2023
|
@MalloD12 could you please take a look on unit test failure? |
|
It's fixed now. Thanks, @rberezen! |
Thank you! |
rberezen
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
A fix to Rollback object serialization that was duplicating the rollback key has been implemented.
Fixes #2084
Things to be aware of
Things to worry about
Additional Context