refactored data clumps

[compf]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Hello maintainers,

I am conducting a master thesis project focused on enhancing code quality through automated refactoring of data clumps, assisted by Large Language Models (LLMs).

Data clump definition

A data clump exists if

1. two methods (in the same or in different classes) have at least 3 common parameters and one of those methods does not override the other, or
2. At least three fields in a class are common with the parameters of a method (in the same or in a different class), or
3. Two different classes have at least three common fields

See also the following UML diagram as an example

I believe these refactoring can contribute to the project by reducing complexity and enhancing readability of your source code.

Pursuant to the EU AI Act, I fully disclose the use of LLMs in generating these refactorings, emphasizing that all changes have undergone human review for quality assurance.

Even if you decide not to integrate my changes to your codebase (which is perfectly fine), I ask you to fill out a feedback survey, which will be scientifically evaluated to determine the acceptance of AI-supported refactorings. You can find the feedback survey under https://campus.lamapoll.de/Data-clump-refactoring/en

Thank you for considering my contribution. I look forward to your feedback. If you have any other questions or comments, feel free to write a comment, or email me under tschoemaker@uni-osnabrueck.de .

Best regards,
Timo Schoemaker
Department of Computer Science
University of Osnabrück

[kevin-atx]

@compf, thank you for your submission. I'll pass this to engineering for review in the next sprint.

[MalloD12]

Since we are using Lombok in some other classes, I think we can also applied to this class. I think adding:

- @Getter
- @Setter
- @AllArgsConstructor

would be fine.

[MalloD12]

Hi @compf,

I think it's a nice readability enhancement, good job! I just left a small review comment in case you want to apply as well.

Thanks,
Daniel.

[compf]

Thank you very much for the feedback. I can apply your feedback by the end of this week if this is ok :)

[compf]

@MalloD12 In have simplified the DataBaseTableIdentifier class as suggested. According to the email notification, You have written more comments but they seem to be deleted or I can't find them anymore. If they are still relevant, I can address them as well :)

[MalloD12]

@MalloD12 In have simplified the DataBaseTableIdentifier class as suggested. According to the email notification, You have written more comments but they seem to be deleted or I can't find them anymore. If they are still relevant, I can address them as well :)

Thank you, @compf! I don't have any additional comments, I posted some other questions I thought some changes couldn't be needed but I realized afterward they were right.

[MalloD12]

Approved.

Thank you for applying our review comment. Changes looks good, same as build/test checks.

Thanks,
Daniel.