DAT-16825 :: RawSqlStatement refactoring #5812

MalloD12 · 2024-04-17T03:57:14Z

Impact

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR is to address the initiative proposed in DAT-16825 to replace RawSqlStatement with RawParameterizedSqlStatement.

Also, since there were some of these changes already created for PR #5546 (Fix sonar scan High issues), I applied these changes starting from that PR. If you agree we can close that one.

Things to be aware of

None

Things to worry about

None

Additional Context

…izedSqlStatement.

…MSSQL db.

- Replacement of string concatenation by StringBuilder.

liquibase-standard/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java

liquibase-integration-tests/src/test/java/liquibase/dbtest/AbstractIntegrationTest.java

liquibase-standard/src/main/java/liquibase/database/core/DatabaseUtils.java

liquibase-standard/src/main/java/liquibase/database/core/SQLiteDatabase.java

liquibase-standard/src/main/java/liquibase/sqlgenerator/core/RawParameterizedSqlGenerator.java

liquibase-standard/src/main/java/liquibase/sqlgenerator/core/RawSqlGenerator.java

liquibase-standard/src/test/java/liquibase/statement/core/RawSqStatementTest.java

….findExceptionInCauseChain method.

liquibase-integration-tests/src/test/java/liquibase/dbtest/pgsql/PostgreSQLIntegrationTest.java

...ibase-snowflake/src/main/java/liquibase/snapshot/jvm/SequenceSnapshotGeneratorSnowflake.java

...owflake/src/main/java/liquibase/snapshot/jvm/UniqueConstraintSnapshotGeneratorSnowflake.java

...-snowflake/src/main/java/liquibase/sqlgenerator/core/SetColumnRemarksGeneratorSnowflake.java

liquibase-standard/src/main/java/liquibase/change/core/AddLookupTableChange.java

filipelautert · 2024-04-22T14:51:46Z

liquibase-standard/src/main/java/liquibase/snapshot/jvm/UniqueConstraintSnapshotGenerator.java

+                                sql.append("and k.constname = ? ");
+                            }
+                            sql.append("and t.tabschema = ? order by colseq");
+                    parameters.add(database.correctObjectName(name, UniqueConstraint.class));


Should be inside the if too

liquibase-standard/src/main/java/liquibase/snapshot/jvm/UniqueConstraintSnapshotGenerator.java

filipelautert · 2024-04-22T14:54:04Z

liquibase-standard/src/main/java/liquibase/snapshot/jvm/UniqueConstraintSnapshotGenerator.java

                    }
                }
-                stmt = new RawSqlStatement(sql);
+                parameters.add(database.getSystemSchema());
+                parameters.add(catalogName);


Add them to the if's...

liquibase-standard/src/main/java/liquibase/sqlgenerator/core/RawParameterizedSqlGenerator.java

MalloD12 · 2024-04-22T18:00:42Z

@filipelautert I addressed almost all your review comments. Regarding the last one:

validationErrors.checkRequiredField("parameters", statement.getParameters(), true);

I opened up a discussion in Slack.

Thanks,
Daniel.

github-actions · 2024-04-30T14:04:06Z

FOSSA Snippets Detection 🤖`success`

Snippets Detection Output


Running FOSSA snippets
 INFO main{target=/home/runner/work/liquibase/liquibase/}: Analyzing local snippet matches
 INFO main{target=/home/runner/work/liquibase/liquibase/}: Finished matching 0 snippets out of 4464 files to 0 matches

Pusher: @MalloD12, Action: pull_request, Working Directory: /home/runner/work/liquibase/liquibase, Workflow: FOSSA License Compliance and Security Check

github-actions · 2024-04-30T14:04:07Z

FOSSA Test 🧪`success`

Test Output



Using project name: `https://github.com/liquibase/liquibase`
Using revision: `35049a4403c0984b0f58ab077e53ac54b576defc`

[ Checking build completion for 35049a4403c0984b0f58ab077e53ac54b576defc... ]
[ Waiting for build completion (revision 35049a4403c0984b0f58ab077e53ac54b576defc)... last status: StatusCreated ]
[ Waiting for build completion (revision 35049a4403c0984b0f58ab077e53ac54b576defc)... last status: StatusCreated ]
[ Waiting for issue scan completion... ]


[ERROR] 

  ========================================================================
  Tested Following Project:
  ========================================================================


  Project Title: https://github.com/liquibase/liquibase
  Project Revision: 35049a4403c0984b0f58ab077e53ac54b576defc
  Project Visibility: private
  Project Targets:
  - maven: [pom.xml]


  COMPLIANCE ISSUES (Total 26)

  ========================================================================
  Flagged by Policy (Total 26)
  ========================================================================
  ⚑ LGPL-3.0-only license detected in com.github.javaparser:javaparser-core@3.25.9
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5053794

  ⚑ LGPL-3.0-or-later license detected in com.github.javaparser:javaparser-core@3.25.9
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5053793

  ⚑ LGPL-3.0-or-later license detected in com.h2database:h2@2.2.224
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4850918

  ⚑ GPL-2.0-with-classpath-exception license detected in com.sun.istack:istack-commons-runtime@4.1.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934920

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.activation:jakarta.activation-api@2.1.3
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5173516

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.annotation:jakarta.annotation-api@2.1.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934922

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.el:jakarta.el-api@5.0.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934924

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.enterprise:jakarta.enterprise.cdi-api@4.0.1
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934916

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.enterprise:jakarta.enterprise.lang-model@4.0.1
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934919

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.interceptor:jakarta.interceptor-api@2.1.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934928

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.servlet:jakarta.servlet-api@5.0.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934931

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.xml.bind:jakarta.xml.bind-api@4.0.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5173517

  ⚑ GPL-2.0-only license detected in javax.activation:javax.activation-api@1.2.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4414991

  ⚑ GPL-2.0-with-classpath-exception license detected in javax.activation:javax.activation-api@1.2.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4414990

  ⚑ GPL-2.0-with-classpath-exception license detected in javax.servlet:javax.servlet-api@3.1.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934935

  ⚑ GPL-2.0-only license detected in javax.xml.bind:jaxb-api@2.3.1
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4414993

  ⚑ GPL-2.0-with-classpath-exception license detected in javax.xml.bind:jaxb-api@2.3.1
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4414992

  ⚑ LGPL-2.1-or-later license detected in net.java.dev.jna:jna@5.13.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/4934934

  ⚑ GPL-2.0-with-classpath-exception license detected in org.eclipse.angus:angus-activation@2.0.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5173515

  ⚑ LGPL-2.1-only license detected in org.firebirdsql.jdbc:jaybird@5.0.4.java8
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5173521

  ⚑ LGPL-3.0-only license detected in org.firebirdsql.jdbc:jaybird@5.0.4.java8
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5173520

  ⚑ GPL-2.0-with-classpath-exception license detected in org.glassfish.jaxb:jaxb-core@4.0.5
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5173518

  ⚑ GPL-2.0-with-classpath-exception license detected in org.glassfish.jaxb:jaxb-runtime@4.0.5
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5173519

  ⚑ GPL-2.0-with-classpath-exception license detected in org.glassfish.jaxb:txw2@4.0.5
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/5173522

  ⚑ GPL-2.0-or-later license detected in org.yaml:snakeyaml@2.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/3779967

  ⚑ LGPL-2.1-or-later license detected in org.yaml:snakeyaml@2.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/35049a4403c0984b0f58ab077e53ac54b576defc/issues/licensing/3779966


[ERROR] An issue occurred

  *** Relevant Errors ***

      �[0;91mError: �[0mThe scan has revealed issues. Number of issues found: 26

Pusher: @MalloD12, Action: pull_request, Working Directory: /home/runner/work/liquibase/liquibase, Workflow: FOSSA License Compliance and Security Check

…to DAT-16825

github-actions · 2024-04-30T21:17:59Z

FOSSA Snippets Detection 🤖`success`

Snippets Detection Output


Running FOSSA snippets
 INFO main{target=/home/runner/work/liquibase/liquibase/}: Analyzing local snippet matches
 INFO main{target=/home/runner/work/liquibase/liquibase/}: Finished matching 0 snippets out of 4464 files to 0 matches

Pusher: @MalloD12, Action: pull_request, Working Directory: /home/runner/work/liquibase/liquibase, Workflow: FOSSA License Compliance and Security Check

github-actions · 2024-04-30T21:18:00Z

FOSSA Test 🧪`success`

Test Output



Using project name: `https://github.com/liquibase/liquibase`
Using revision: `19fe5b8b91363a92937b897ef34dde07a34ab0fd`

[ Checking build completion for 19fe5b8b91363a92937b897ef34dde07a34ab0fd... ]
[ Waiting for build completion (revision 19fe5b8b91363a92937b897ef34dde07a34ab0fd)... last status: StatusCreated ]
[ Waiting for build completion (revision 19fe5b8b91363a92937b897ef34dde07a34ab0fd)... last status: StatusCreated ]
[ Waiting for build completion (revision 19fe5b8b91363a92937b897ef34dde07a34ab0fd)... last status: StatusCreated ]
[ Waiting for build completion (revision 19fe5b8b91363a92937b897ef34dde07a34ab0fd)... last status: StatusCreated ]
[ Waiting for build completion (revision 19fe5b8b91363a92937b897ef34dde07a34ab0fd)... last status: StatusCreated ]
[ Waiting for build completion (revision 19fe5b8b91363a92937b897ef34dde07a34ab0fd)... last status: StatusCreated ]
[ Waiting for build completion (revision 19fe5b8b91363a92937b897ef34dde07a34ab0fd)... last status: StatusCreated ]
[ Waiting for build completion (revision 19fe5b8b91363a92937b897ef34dde07a34ab0fd)... last status: StatusCreated ]
[ Waiting for issue scan completion... ]


[ERROR] 

  ========================================================================
  Tested Following Project:
  ========================================================================


  Project Title: https://github.com/liquibase/liquibase
  Project Revision: 19fe5b8b91363a92937b897ef34dde07a34ab0fd
  Project Visibility: private
  Project Targets:
  - maven: [pom.xml]


  COMPLIANCE ISSUES (Total 26)

  ========================================================================
  Flagged by Policy (Total 26)
  ========================================================================
  ⚑ LGPL-3.0-only license detected in com.github.javaparser:javaparser-core@3.25.9
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5053794

  ⚑ LGPL-3.0-or-later license detected in com.github.javaparser:javaparser-core@3.25.9
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5053793

  ⚑ LGPL-3.0-or-later license detected in com.h2database:h2@2.2.224
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4850918

  ⚑ GPL-2.0-with-classpath-exception license detected in com.sun.istack:istack-commons-runtime@4.1.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934920

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.activation:jakarta.activation-api@2.1.3
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5173516

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.annotation:jakarta.annotation-api@2.1.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934922

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.el:jakarta.el-api@5.0.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934924

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.enterprise:jakarta.enterprise.cdi-api@4.0.1
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934916

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.enterprise:jakarta.enterprise.lang-model@4.0.1
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934919

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.interceptor:jakarta.interceptor-api@2.1.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934928

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.servlet:jakarta.servlet-api@5.0.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934931

  ⚑ GPL-2.0-with-classpath-exception license detected in jakarta.xml.bind:jakarta.xml.bind-api@4.0.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5173517

  ⚑ GPL-2.0-only license detected in javax.activation:javax.activation-api@1.2.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4414991

  ⚑ GPL-2.0-with-classpath-exception license detected in javax.activation:javax.activation-api@1.2.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4414990

  ⚑ GPL-2.0-with-classpath-exception license detected in javax.servlet:javax.servlet-api@3.1.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934935

  ⚑ GPL-2.0-only license detected in javax.xml.bind:jaxb-api@2.3.1
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4414993

  ⚑ GPL-2.0-with-classpath-exception license detected in javax.xml.bind:jaxb-api@2.3.1
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4414992

  ⚑ LGPL-2.1-or-later license detected in net.java.dev.jna:jna@5.13.0
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/4934934

  ⚑ GPL-2.0-with-classpath-exception license detected in org.eclipse.angus:angus-activation@2.0.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5173515

  ⚑ LGPL-2.1-only license detected in org.firebirdsql.jdbc:jaybird@5.0.4.java8
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5173521

  ⚑ LGPL-3.0-only license detected in org.firebirdsql.jdbc:jaybird@5.0.4.java8
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5173520

  ⚑ GPL-2.0-with-classpath-exception license detected in org.glassfish.jaxb:jaxb-core@4.0.5
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5173518

  ⚑ GPL-2.0-with-classpath-exception license detected in org.glassfish.jaxb:jaxb-runtime@4.0.5
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5173519

  ⚑ GPL-2.0-with-classpath-exception license detected in org.glassfish.jaxb:txw2@4.0.5
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/5173522

  ⚑ GPL-2.0-or-later license detected in org.yaml:snakeyaml@2.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/3779967

  ⚑ LGPL-2.1-or-later license detected in org.yaml:snakeyaml@2.2
  More information: https://app.fossa.com/projects/custom%2B40163%2Fgithub.com%2Fliquibase%2Fliquibase/refs/branch/master/19fe5b8b91363a92937b897ef34dde07a34ab0fd/issues/licensing/3779966


[ERROR] An issue occurred

  *** Relevant Errors ***

      �[0;91mError: �[0mThe scan has revealed issues. Number of issues found: 26

Pusher: @MalloD12, Action: pull_request, Working Directory: /home/runner/work/liquibase/liquibase, Workflow: FOSSA License Compliance and Security Check

MalloD12 added 12 commits March 25, 2024 15:16

Replace string contatenations by using StringBuilder and RawParameter…

c583675

…izedSqlStatement.

Adjustments needed to fix SQl queries for some of the DBs.

9a70afc

SQL updates to MSSQL queries.

c983181

String format command fixed to make use of provided parameter.

3d257df

Parameter replacement way updated for SequecenceSnapshotGenerator of …

3e9a33e

…MSSQL db.

Merge branch 'master' into fix-issue-5546

3b933bb

Fix SequenceSnapshotGenerator sql query.

76c22f4

Merge branch 'master' into fix-issue-5546

b679da8

Merge branch 'master' into fix-issue-5546

ef3631a

- Replacement of RawSqlStatement by RawParameterizedSqlStatement.

8043b0d

- Replacement of string concatenation by StringBuilder.

Merge branch 'master' into DAT-16825

d5bc7c4

Removed commented code.

a464b99

MalloD12 added the TypeEnhancement label Apr 17, 2024

MalloD12 self-assigned this Apr 17, 2024

MalloD12 requested a review from filipelautert as a code owner April 17, 2024 03:57

MalloD12 temporarily deployed to internal April 17, 2024 03:57 — with GitHub Actions Inactive

github-advanced-security bot found potential problems Apr 17, 2024

View reviewed changes

liquibase-standard/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java Fixed Show fixed Hide fixed

liquibase-standard/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java Fixed Show fixed Hide fixed

Integration tests fixes.

748b91d

MalloD12 temporarily deployed to internal April 17, 2024 16:05 — with GitHub Actions Inactive

Fix test assertion of testInvalidSqlThrowsException.

7f9b719

MalloD12 temporarily deployed to internal April 17, 2024 16:38 — with GitHub Actions Inactive

Update testInvalidSqlThrowsException test.

4eed840

MalloD12 temporarily deployed to internal April 17, 2024 17:33 — with GitHub Actions Inactive

MalloD12 assigned filipelautert and unassigned MalloD12 Apr 17, 2024

MalloD12 requested review from wwillard7800 and StevenMassaro April 17, 2024 17:40

StevenMassaro reviewed Apr 17, 2024

View reviewed changes

MalloD12 added 2 commits April 18, 2024 10:38

Merge branch 'master' into DAT-16825

b531ed1

Review comments addressed.

712582a

MalloD12 linked an issue Apr 18, 2024 that may be closed by this pull request

Fix string concatenation code-scan issues #5546

Open

2 tasks

MalloD12 added 2 commits April 18, 2024 15:56

Merge branch 'master' into DAT-16825

bea4136

Fixed RawParameterized query parameter.

b5ecdb3

MalloD12 temporarily deployed to internal April 18, 2024 19:53 — with GitHub Actions Inactive

StevenMassaro approved these changes Apr 19, 2024

View reviewed changes

MalloD12 added 2 commits April 19, 2024 11:33

Merge branch 'master' into DAT-16825

82c2943

test (testInvalidSqlThrowsException) refactoring to use ExceptionUtil…

bee8718

….findExceptionInCauseChain method.

MalloD12 temporarily deployed to internal April 19, 2024 16:07 — with GitHub Actions Inactive

suryaaki2 approved these changes Apr 22, 2024

View reviewed changes

filipelautert requested changes Apr 22, 2024

View reviewed changes

MalloD12 added 2 commits April 22, 2024 12:25

Merge branch 'master' into DAT-16825

8116bac

More review comments addressed.

5f077ae

MalloD12 temporarily deployed to internal April 22, 2024 17:59 — with GitHub Actions Inactive

Allow empty parameters.

a95f202

MalloD12 temporarily deployed to internal April 22, 2024 18:06 — with GitHub Actions Inactive

filipelautert self-requested a review April 22, 2024 19:43

filipelautert approved these changes Apr 22, 2024

View reviewed changes

MalloD12 and others added 2 commits April 29, 2024 16:55

Merge branch 'master' into DAT-16825

33304ad

Merge branch 'master' into DAT-16825

1331f8c

MalloD12 temporarily deployed to internal April 30, 2024 14:01 — with GitHub Actions Inactive

MalloD12 added 3 commits April 30, 2024 18:10

SQL parameter replacement updated to avoid an invalid replacement.

114d764

Merge branch 'master' into DAT-16825

751f227

Merge branch 'DAT-16825' of https://github.com/liquibase/liquibase in…

252de70

…to DAT-16825

MalloD12 temporarily deployed to internal April 30, 2024 21:15 — with GitHub Actions Inactive

StevenMassaro added the do-not-merge label May 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAT-16825 :: RawSqlStatement refactoring #5812

DAT-16825 :: RawSqlStatement refactoring #5812

MalloD12 commented Apr 17, 2024 •

edited by jira bot

filipelautert Apr 22, 2024

filipelautert Apr 22, 2024

MalloD12 commented Apr 22, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

DAT-16825 :: RawSqlStatement refactoring #5812

Are you sure you want to change the base?

DAT-16825 :: RawSqlStatement refactoring #5812

Conversation

MalloD12 commented Apr 17, 2024 • edited by jira bot

Impact

Description

Things to be aware of

Things to worry about

Additional Context

filipelautert Apr 22, 2024

Choose a reason for hiding this comment

filipelautert Apr 22, 2024

Choose a reason for hiding this comment

MalloD12 commented Apr 22, 2024

github-actions bot commented Apr 30, 2024

FOSSA Snippets Detection 🤖success

github-actions bot commented Apr 30, 2024

FOSSA Test 🧪success

github-actions bot commented Apr 30, 2024

FOSSA Snippets Detection 🤖success

github-actions bot commented Apr 30, 2024

FOSSA Test 🧪success

MalloD12 commented Apr 17, 2024 •

edited by jira bot

FOSSA Snippets Detection 🤖`success`

FOSSA Test 🧪`success`

FOSSA Snippets Detection 🤖`success`

FOSSA Test 🧪`success`