[DAT-17482] Integrating Bigquery into liquibase #5838
+6,196
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run test-harness on main branch
Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.9 to 0.8.10. - [Release notes](https://github.com/jacoco/jacoco/releases) - [Commits](jacoco/jacoco@v0.8.9...v0.8.10) --- updated-dependencies: - dependency-name: org.jacoco:jacoco-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google-cloud-bigquerystorage](https://github.com/googleapis/java-bigquerystorage) from 2.34.2 to 2.36.1. - [Release notes](https://github.com/googleapis/java-bigquerystorage/releases) - [Changelog](https://github.com/googleapis/java-bigquerystorage/blob/main/CHANGELOG.md) - [Commits](googleapis/java-bigquerystorage@v2.34.2...v2.36.1) --- updated-dependencies: - dependency-name: com.google.cloud:google-cloud-bigquerystorage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google-cloud-bigquery](https://github.com/googleapis/java-bigquery) from 2.24.4 to 2.25.0. - [Release notes](https://github.com/googleapis/java-bigquery/releases) - [Changelog](https://github.com/googleapis/java-bigquery/blob/main/CHANGELOG.md) - [Commits](googleapis/java-bigquery@v2.24.4...v2.25.0) --- updated-dependencies: - dependency-name: com.google.cloud:google-cloud-bigquery dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.12.0 to 26.14.0. - [Release notes](https://github.com/googleapis/java-cloud-bom/releases) - [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/CHANGELOG.md) - [Commits](googleapis/java-cloud-bom@v26.12.0...v26.14.0) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…oud-libraries-bom-26.14.0 Bump libraries-bom from 26.12.0 to 26.14.0
…oud-google-cloud-bigquery-2.25.0 Bump google-cloud-bigquery from 2.24.4 to 2.25.0
…oud-google-cloud-bigquerystorage-2.36.1 Bump google-cloud-bigquerystorage from 2.34.2 to 2.36.1
…coco-maven-plugin-0.8.10 Bump jacoco-maven-plugin from 0.8.9 to 0.8.10
…picocli-4.7.3 Bump picocli from 4.7.2 to 4.7.3
…sion-4.21.1 Bump liquibase.version from 4.21.0 to 4.21.1
BigQuery: Fix Quoting Character
Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0...surefire-3.1.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ven.plugins-maven-surefire-plugin-3.1.0 Bump maven-surefire-plugin from 3.0.0 to 3.1.0
Bumps `liquibase.version` from 4.21.1 to 4.22.0. Updates `liquibase-core` from 4.21.1 to 4.22.0 - [Release notes](https://github.com/liquibase/liquibase/releases) - [Changelog](https://github.com/liquibase/liquibase/blob/master/changelog.txt) - [Commits](v4.21.1...v4.22.0) Updates `liquibase-maven-plugin` from 4.21.1 to 4.22.0 - [Release notes](https://github.com/liquibase/liquibase/releases) - [Changelog](https://github.com/liquibase/liquibase/blob/master/changelog.txt) - [Commits](v4.21.1...v4.22.0) --- updated-dependencies: - dependency-name: org.liquibase:liquibase-core dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.liquibase:liquibase-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…sion-4.22.0 Bump liquibase.version from 4.21.1 to 4.22.0
Bumps [picocli](https://github.com/remkop/picocli) from 4.7.3 to 4.7.4. - [Release notes](https://github.com/remkop/picocli/releases) - [Changelog](https://github.com/remkop/picocli/blob/main/RELEASE-NOTES.md) - [Commits](remkop/picocli@v4.7.3...v4.7.4) --- updated-dependencies: - dependency-name: info.picocli:picocli dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…picocli-4.7.4 Bump picocli from 4.7.3 to 4.7.4
Bumps [google-cloud-bigquery](https://github.com/googleapis/java-bigquery) from 2.25.0 to 2.28.0. - [Release notes](https://github.com/googleapis/java-bigquery/releases) - [Changelog](https://github.com/googleapis/java-bigquery/blob/main/CHANGELOG.md) - [Commits](googleapis/java-bigquery@v2.25.0...v2.28.0) --- updated-dependencies: - dependency-name: com.google.cloud:google-cloud-bigquery dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…oud-google-cloud-bigquery-2.28.0 Bump google-cloud-bigquery from 2.25.0 to 2.28.0
Bumps [google-http-client](https://github.com/googleapis/google-http-java-client) from 1.43.1 to 1.43.3. - [Release notes](https://github.com/googleapis/google-http-java-client/releases) - [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md) - [Commits](googleapis/google-http-java-client@v1.43.1...v1.43.3) --- updated-dependencies: - dependency-name: com.google.http-client:google-http-client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tp-client-google-http-client-1.43.3 Bump google-http-client from 1.43.1 to 1.43.3
Bumps [google-cloud-bigquerystorage](https://github.com/googleapis/java-bigquerystorage) from 2.36.1 to 2.39.0. - [Release notes](https://github.com/googleapis/java-bigquerystorage/releases) - [Changelog](https://github.com/googleapis/java-bigquerystorage/blob/main/CHANGELOG.md) - [Commits](googleapis/java-bigquerystorage@v2.36.1...v2.39.0) --- updated-dependencies: - dependency-name: com.google.cloud:google-cloud-bigquerystorage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…oud-google-cloud-bigquerystorage-2.39.0 Bump google-cloud-bigquerystorage from 2.36.1 to 2.39.0
Bumps [google-cloud-bigquery](https://github.com/googleapis/java-bigquery) from 2.28.0 to 2.29.0. - [Release notes](https://github.com/googleapis/java-bigquery/releases) - [Changelog](https://github.com/googleapis/java-bigquery/blob/main/CHANGELOG.md) - [Commits](googleapis/java-bigquery@v2.28.0...v2.29.0) --- updated-dependencies: - dependency-name: com.google.cloud:google-cloud-bigquery dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…oud-google-cloud-bigquery-2.29.0 Bump google-cloud-bigquery from 2.28.0 to 2.29.0
Bumps `liquibase.version` from 4.22.0 to 4.23.0. Updates `liquibase-core` from 4.22.0 to 4.23.0 - [Release notes](https://github.com/liquibase/liquibase/releases) - [Changelog](https://github.com/liquibase/liquibase/blob/master/changelog.txt) - [Commits](v4.22.0...v4.23.0) Updates `liquibase-maven-plugin` from 4.22.0 to 4.23.0 - [Release notes](https://github.com/liquibase/liquibase/releases) - [Changelog](https://github.com/liquibase/liquibase/blob/master/changelog.txt) - [Commits](v4.22.0...v4.23.0) --- updated-dependencies: - dependency-name: org.liquibase:liquibase-core dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.liquibase:liquibase-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
KushnirykOleh
approved these changes
Apr 26, 2024
vitaliimak
reviewed
Apr 29, 2024
.../src/main/java/liquibase/sqlgenerator/BigqueryCreateDatabaseChangeLogLockTableGenerator.java
Outdated
Show resolved
Hide resolved
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
liquibase-bigquery/src/main/java/liquibase/snapshot/jvm/BigQueryViewSnapshotGenerator.java
Fixed
Show fixed
Hide fixed
liquibase-bigquery/src/main/java/liquibase/sqlgenerator/BigQueryInsertOrUpdateGenerator.java
Fixed
Show fixed
Hide fixed
liquibase-bigquery/src/main/java/liquibase/sqlgenerator/BigQueryUpdateGenerator.java
Fixed
Show fixed
Hide fixed
liquibase-bigquery/src/main/java/liquibase/database/BigQueryConnection.java
Dismissed
Show dismissed
Hide dismissed
filipelautert
changed the title
Add BigQuery unit tests
vitaliimak
reviewed
May 15, 2024
| Scope.getCurrentScope().getLog(this.getClass()).info("Sequences are not supported by BigQuery"); | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Hi @filipelautert
When I added Function support to BigQuerry I got the next error if the getSelectSequenceStatement and replaces methods were removed
At the same time, the SQL from the bigquery repository was incorrect, so I had to fix it
https://github.com/liquibase/liquibase-bigquery/blob/main/src/main/java/liquibase/ext/bigquery/snapshot/jvm/BigQuerySequenceSnapshotGenerator.java#L52
"SELECT NULL AS SEQUENCE_NAME, NULL AS START_VALUE, NULL AS MIN_VALUE, NULL AS MAX_VALUE, " +
"NULL AS INCREMENT_BY, " +
"NULL AS WILL_CYCLE " +
"FROM " +
jdbcSchemaName + "." + database.getSystemSchema().toUpperCase() + ".COLUMNS WHERE 1=0");
Should the methods be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Things to be aware of
Things to worry about
Additional Context