Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAT-17403] resolved priorities for Datatypes and ModifyDatatype generator #5913

Merged
merged 1 commit into from
May 16, 2024
Merged

[DAT-17403] resolved priorities for Datatypes and ModifyDatatype generator #5913

merged 1 commit into from
May 16, 2024

Conversation

KushnirykOleh
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

2 issues here

  • Added priority method to BigQueryModifyDataTypeGenerator - as it had default priority is was suppressed by other extensions in classpath. This resolved query to have SET DATA TYPE instead of just TYPE
  • Fixed priorities for datatypes as NumericDataTypeBigQuery was never used and we had NUMBER in the query instead of NUMERIC

@KushnirykOleh KushnirykOleh merged commit 966d051 into DAT-17482 May 16, 2024
34 of 36 checks passed
@KushnirykOleh KushnirykOleh deleted the DAT-17403 branch May 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliimak vitaliimak vitaliimak approved these changes

@filipelautert filipelautert filipelautert approved these changes

Assignees
No one assigned
Labels
TypeBug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KushnirykOleh @vitaliimak @filipelautert