Add support to disable fast-check #5917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MosheElisha
reviewed
May 14, 2024
| @@ -67,6 +69,10 @@ public class Liquibase implements AutoCloseable { | |||
| private final DefaultChangeExecListener defaultChangeExecListener = new DefaultChangeExecListener(); | |||
| private final Map<String, Boolean> upToDateFastCheck = new HashMap<>(); | |||
|
|
|||
| @Getter | |||
| @Setter | |||
| private Boolean fast_check_disabled = Boolean.FALSE; | |||
There was a problem hiding this comment.
Consider using positive - fastCheckEnabled to make it easier to understand if it is enabled or disabled.
There was a problem hiding this comment.
Yeah, I can rename it if we want to move forward with this PR. I thought calling it this way (fast_check_disabled) because by default this configuration would stay active, but yes I'm fine renaming it.
| @@ -254,6 +254,7 @@ public void afterPropertiesSet() throws LiquibaseException { | |||
| final Connection c = getDataSource().getConnection(); | |||
| liquibase = createLiquibase(c); | |||
| generateRollbackFile(liquibase); | |||
| liquibase.setFast_check_disabled(Boolean.TRUE); | |||
There was a problem hiding this comment.
Should we change the default? This might cause a small performance hit, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Fixes #5784
Things to be aware of
Things to worry about
Additional Context