Use the method setBlob to insert blob data #605

xjodoin · 2016-09-16T12:36:55Z

On postgresql if you use setBinaryStream the field must be of type bytea but a blob type is oid (ref pull request #600). Instead you must use setBlob method to be able to insert or update data with valueBlobFile

candrews · 2016-11-07T17:42:38Z

Reported https://liquibase.jira.com/browse/CORE-2937 for this issue.

candrews · 2016-11-30T15:01:43Z

@nvoxland can you please take a look at this PR?

xjodoin · 2018-03-23T12:20:25Z

rebase the pull request on master

Alemorato · 2018-05-23T09:52:09Z

any change to be merged?

xjodoin · 2018-05-23T12:13:15Z

the issue still open https://liquibase.jira.com/browse/CORE-2937

Alemorato · 2018-05-30T12:34:46Z

we are using these change since a month for our internal builders and it works.

@xjodoin if you provides some unit test maybe the liquibase team could be more encouraged for merge

nictas · 2018-06-25T12:01:23Z

Any news on this? We tried adopting version 3.6.1 of Liquibase, but we also encountered the issue mentioned here. We would really appreciate a fix for it.

Fix for the issue describe in https://liquibase.jira.com/browse/CORE-2937 using the solution proposed by liquibase#605.

xjodoin · 2019-03-27T18:49:29Z

Is there a reason you don't merge this pull request?

hypery2k · 2019-12-18T05:53:05Z

any news on this PR?

hypery2k · 2019-12-30T13:14:43Z

@nvoxland Any chance to get this merged?

In PostgreSQL, Liquibase maps the `blob` type to an `oid` column by default[1]. That column type is not supported[2] very well when using the `valueBlobFile` attribute, which expects a `bytea` column instead. This was confirmed on all PostgreSQL versions starting from 9.6. The `validCheckSum` attribute does not need to be updated since it was already for the previous (binary_type, varchar_type) combination in an unrelated commit (78a99d5). Fixes airsonic#1213. [1] https://liquibase.jira.com/browse/CORE-1863 [2] liquibase/liquibase#605

In PostgreSQL, Liquibase maps the `blob` type to an `oid` column by default[1]. That column type is not supported[2] very well when using the `valueBlobFile` attribute, which expects a `bytea` column instead. This was confirmed on all PostgreSQL versions starting from 9.6. The `validCheckSum` attribute does not need to be updated since it was already for the previous (binary_type, varchar_type) combination in an unrelated commit (78a99d5). Fixes tesshucom#1213. [1] https://liquibase.jira.com/browse/CORE-1863 [2] liquibase/liquibase#605

siyerlin · 2020-05-04T07:46:52Z

Any updates on this? We are also encountering this problem. Would it help if we still keep the setBinaryStream as default, and introduce a new column config for the setBlob? Thanks!

ro-rah · 2020-05-13T20:29:32Z

Hi @xjodoin

Sorry for the long delay, I am getting this ready for conditioning, it looks pretty straight forward, if you include tests I can size this down. For now I will leave at a Med.

Here is some good info in my typical response to PR submitters:
Thanks for your pull request!

Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest:

Changes based on guidelines for PR submission
Additional tests (unit and/or integration)
Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

liquibot · 2020-06-04T13:39:46Z

➤ Erzsebet Carmean commented:

Thank you for the response, Nathan!

CC: [~accountid:557058:c8f0b24d-f02f-431c-8842-fd9c929dfbf2]

…/liquibase into xjodoin-fix_postgres_blob_insert

github-actions · 2022-05-28T05:12:58Z

Unit Test Results

  4 512 files ±0   4 512 suites ±0 33m 15s ⏱️ +46s
  4 419 tests ±0   4 205 ✔️ +4   214 💤 - 4 0 ❌ ±0
52 308 runs ±0 47 300 ✔️ +4 5 008 💤 - 4 0 ❌ ±0

Results for commit e29ca27. ± Comparison against base commit 4ab687b.

XDelphiGrl · 2022-06-02T13:33:27Z

@nvoxland, hi! Do we need to worry about the impact of the Java version with this change? I was doing some light reading on Ye Olde Internet and saw this post:

StackoverFlow

I'm trying to figure out if QA should manually test this with different Java versions.

CC @suryaaki

nvoxland · 2022-06-07T15:59:34Z

@XDelphiGrl It wouldn't be a java version thing, but a driver version. Like from the post, postgresql's 9.4 driver didn't work with setBlob. But that has since been fixed, as we see in the automated testing for this ticket. It won't matter the java version we use, but we do run those automated tests with java 8 and they pass.

XDelphiGrl

Fix is targeted to managing LOB content in the applyColumnParameter method.
No additional testing required.

APPROVED

Passing Test Harness Run
Functional Test Results
Note Functional test failures are for the quality checks feature and unrelated to this change.

xjodoin · 2022-06-07T17:16:54Z

Thanks @XDelphiGrl to approved my pull request

XDelphiGrl · 2022-06-07T19:01:42Z

Thanks @XDelphiGrl to approved my pull request

Thank you, @xjodoin, for the PR. I hope you have a lovely day!

candrews mentioned this pull request Nov 7, 2016

CORE-1863 Fix Postgres BLOB type mappings #600

Merged

xjodoin force-pushed the fix_postgres_blob_insert branch from a30e8de to dea450d Compare March 23, 2018 12:19

ThiagoGesser pushed a commit to ThiagoGesser/liquibase that referenced this pull request Oct 10, 2018

PostgreSQL blob fix

c820c37

Fix for the issue describe in https://liquibase.jira.com/browse/CORE-2937 using the solution proposed by liquibase#605.

Use the method setBlob to insert blob data

873f966

xjodoin force-pushed the fix_postgres_blob_insert branch from dea450d to 873f966 Compare April 12, 2019 17:56

fxthomas mentioned this pull request Jan 3, 2020

Change avatar storage column to bytea for PostgreSQL airsonic/airsonic#1452

Closed

datical-jenkins added the Status:Discovery label Mar 3, 2020

datical-jenkins changed the title ~~Use the method setBlob to insert blob data~~ LB-104 ⁃ Use the method setBlob to insert blob data Mar 4, 2020

datical-jenkins changed the title ~~LB-104 ⁃ Use the method setBlob to insert blob data~~ Use the method setBlob to insert blob data Mar 5, 2020

datical-jenkins added Status:Discovery and removed Status:Discovery labels Mar 25, 2020

ro-rah removed the StatusDiscovery label May 13, 2020

molivasdat removed the Target4.0-beta2 label Oct 14, 2020

sync-by-unito bot added Target4.1.2 labels Oct 20, 2020

kataggart added DBPostgres and removed StatusConditioning labels May 23, 2022

kataggart added this to To Do in Conditioning++ via automation May 23, 2022

kataggart added the daily_review label May 23, 2022

Merge branch 'fix_postgres_blob_insert' of https://github.com/xjodoin…

e29ca27

…/liquibase into xjodoin-fix_postgres_blob_insert

nvoxland added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label May 28, 2022

nvoxland changed the base branch from master to 1_9 May 28, 2022 04:52

nvoxland changed the base branch from 1_9 to master May 28, 2022 04:52

nvoxland added the autocandidate label May 29, 2022

nvoxland requested review from suryaaki2 and XDelphiGrl May 29, 2022 05:57

kataggart removed the daily_review label May 31, 2022

suryaaki2 approved these changes Jun 3, 2022

View reviewed changes

XDelphiGrl approved these changes Jun 7, 2022

View reviewed changes

kataggart added this to the NEXT milestone Jun 7, 2022

nvoxland merged commit d31a2fe into liquibase:master Jun 8, 2022

Conditioning++ automation moved this from To Do to Done Jun 8, 2022

kataggart mentioned this pull request Aug 10, 2022

Problem inserting valueBlobFile into bytea column postgres #3165

Closed

filipelautert mentioned this pull request Oct 17, 2022

Ensures that Postgresql works with blob types bytea and oid (large objects) #3381

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the method setBlob to insert blob data #605

Use the method setBlob to insert blob data #605

xjodoin commented Sep 16, 2016 •

edited by sync-by-unito bot

candrews commented Nov 7, 2016

candrews commented Nov 30, 2016

xjodoin commented Mar 23, 2018

Alemorato commented May 23, 2018

xjodoin commented May 23, 2018

Alemorato commented May 30, 2018

nictas commented Jun 25, 2018

xjodoin commented Mar 27, 2019

hypery2k commented Dec 18, 2019

hypery2k commented Dec 30, 2019

siyerlin commented May 4, 2020

ro-rah commented May 13, 2020

liquibot commented Jun 4, 2020

github-actions bot commented May 28, 2022

XDelphiGrl commented Jun 2, 2022

nvoxland commented Jun 7, 2022

XDelphiGrl left a comment

xjodoin commented Jun 7, 2022

XDelphiGrl commented Jun 7, 2022

Use the method setBlob to insert blob data #605

Use the method setBlob to insert blob data #605

Conversation

xjodoin commented Sep 16, 2016 • edited by sync-by-unito bot

candrews commented Nov 7, 2016

candrews commented Nov 30, 2016

xjodoin commented Mar 23, 2018

Alemorato commented May 23, 2018

xjodoin commented May 23, 2018

Alemorato commented May 30, 2018

nictas commented Jun 25, 2018

xjodoin commented Mar 27, 2019

hypery2k commented Dec 18, 2019

hypery2k commented Dec 30, 2019

siyerlin commented May 4, 2020

ro-rah commented May 13, 2020

liquibot commented Jun 4, 2020

github-actions bot commented May 28, 2022

Unit Test Results

XDelphiGrl commented Jun 2, 2022

nvoxland commented Jun 7, 2022

XDelphiGrl left a comment

Choose a reason for hiding this comment

xjodoin commented Jun 7, 2022

XDelphiGrl commented Jun 7, 2022

xjodoin commented Sep 16, 2016 •

edited by sync-by-unito bot