-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing catalog on add column rollback #921
Fix missing catalog on add column rollback #921
Conversation
When rollback script for "add column" change is generated, catalog name is missing from generated SQL. As a result of that the rollback may not work if the affected table is not in the default catalog.
Hi @jandurovec Thanks for your pull request! Here’s what happens next: A member of the Liquibase team will take a look at your contribution and may suggest We’ll let you know when it’s ready to move to the next step or if any changes are needed. |
Adding Risk low as it fixes a break and includes unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and test results:
Things to be aware of:
- Changes make sense to me
- Added unit test to ensure data is being copied correctly
Things to worry about:
- Nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix preserves the catalog name when generating drop column SQL.
- A new unit test validates the catalog, schema and table name are all included in a drop column statement.
APPROVED
Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen. |
When rollback script for "add column" change is generated, catalog name is missing from generated SQL. As a result of that the rollback may not work if the affected table is not in the default catalog.