Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing catalog on add column rollback #921

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Fix missing catalog on add column rollback #921

merged 2 commits into from
Sep 19, 2022

Conversation

jandurovec
Copy link
Contributor

@jandurovec jandurovec commented Sep 27, 2019

When rollback script for "add column" change is generated, catalog name is missing from generated SQL. As a result of that the rollback may not work if the affected table is not in the default catalog.

When rollback script for "add column" change is generated, catalog name
is missing from generated SQL. As a result of that the rollback may not
work if the affected table is not in the default catalog.
@datical-jenkins datical-jenkins changed the title Fix missing catalog on add column rollback LB-49 ⁃ Fix missing catalog on add column rollback Mar 4, 2020
@datical-jenkins datical-jenkins changed the title LB-49 ⁃ Fix missing catalog on add column rollback Fix missing catalog on add column rollback Mar 5, 2020
@ro-rah
Copy link

ro-rah commented Apr 27, 2020

Hi @jandurovec

Thanks for your pull request!

Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest
changes, additional tests, or provide other feedback. The PR will be prioritized
according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

@ro-rah
Copy link

ro-rah commented Apr 27, 2020

Adding Risk low as it fixes a break and includes unit tests

@nvoxland nvoxland self-requested a review as a code owner August 30, 2022 17:51
@nvoxland nvoxland added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Aug 30, 2022
@github-actions
Copy link

github-actions bot commented Aug 30, 2022

Unit Test Results

  4 620 files  ±  0    4 620 suites  ±0   37m 53s ⏱️ +26s
  4 618 tests +  1    4 403 ✔️ +  5     215 💤  - 4  0 ±0 
54 588 runs  +12  49 568 ✔️ +16  5 020 💤  - 4  0 ±0 

Results for commit 337283a. ± Comparison against base commit e742a88.

♻️ This comment has been updated with latest results.

@nvoxland nvoxland changed the base branch from master to 1_9 August 31, 2022 16:10
@nvoxland nvoxland changed the base branch from 1_9 to master August 31, 2022 16:10
Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and test results:

Things to be aware of:

  • Changes make sense to me
  • Added unit test to ensure data is being copied correctly

Things to worry about:

  • Nothing

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix preserves the catalog name when generating drop column SQL.

  • A new unit test validates the catalog, schema and table name are all included in a drop column statement.

APPROVED

@nvoxland nvoxland merged commit 5e3f36d into liquibase:master Sep 19, 2022
@kataggart kataggart added this to the NEXT milestone Sep 20, 2022
@tabbyf00
Copy link

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocandidate DBAll featureRollback ImpactLow IntegrationAny RiskLow Trivial changes in spelling, documentation changes, focused bug fixes, etc. SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions Severity3 sprint2022-34 ThemeChangeTypes TypeBug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

10 participants