Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kraken230 firmware 2 image support #692

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Kraken230 firmware 2 image support #692

wants to merge 10 commits into from
+76 −12

Conversation

sophipl
Copy link

@sophipl sophipl commented Apr 7, 2024 •
edited

Added ability to set images for Kraken with firmware version 2

Fixes: #631
Closes:
Related:

Checklist:

  • Adhere to the development process
  • Conform to the style guide
  • Verify that the changes work as expected on real hardware
  • Add automated tests cases
  • Verify that all (other) automated tests (still) pass
  • Update/add documentation

@HomeReactor
Kraken3 firmware 2 image setting initial version
bdb4b60
@HomeReactor
Fixed firmware variable being not initialized
95b922c 
Set image sending twice to avoid no change after USB device initialization
@sophipl
Copy link
Author

sophipl commented Apr 7, 2024 •
edited

So I wrote the solution to send the image to the AIO LCD.
However after usb reset/disconnect, the image needs to be sent twice, otherwise no effect.
One solution is to send it twice all the time.

The manufacturer software sends it twice too.

BTW I don't know why the commits went from my second account that I don't use :), probably git config thing

@sophipl sophipl changed the title Kraken230 fw2 image support support Kraken230 firmware 2 image support Apr 7, 2024
aleksamagicka
aleksamagicka requested changes May 10, 2024
View reviewed changes
liquidctl/driver/kraken3.py Outdated Show resolved Hide resolved
liquidctl/driver/kraken3.py Outdated Show resolved Hide resolved
liquidctl/driver/kraken3.py Outdated Show resolved Hide resolved
liquidctl/driver/kraken3.py Outdated Show resolved Hide resolved
liquidctl/driver/kraken3.py Outdated Show resolved Hide resolved
liquidctl/driver/kraken3.py Outdated Show resolved Hide resolved
liquidctl/driver/kraken3.py Outdated Show resolved Hide resolved
@aleksamagicka
Copy link
Member

Also:

  • Docs should be updated to note that GIFs are not supported on 2.X on 2023 models
  • I guess test_krakenz3_screen_not_totally_broken_part2() should be updated to cover this case? (Although it's broken for other reasons right now)

Thanks!

@sophipl
Copy link
Author

sophipl commented May 18, 2024

I added potential fix for test_krakenz3_screen_not_totally_broken_part2 case
However this testcase is not related to this pull request since it is about gif handling

@sophipl
Copy link
Author

sophipl commented May 19, 2024

Anything else I need to do?

@sophipl
Copy link
Author

sophipl commented May 25, 2024

@aleksamagicka @jonasmalacofilho please tell me what I need to do to merge this change?
I believe I addressed all @aleksamagicka points.
Sorry, I'm new to this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasmalacofilho jonasmalacofilho jonasmalacofilho left review comments

@aleksamagicka aleksamagicka aleksamagicka requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firmware 2.0.1 breaks Kraken 2023 support
4 participants
@sophipl @aleksamagicka @jonasmalacofilho @HomeReactor