Kraken230 firmware 2 image support

[sophipl]

Added ability to set images for Kraken with firmware version 2

Fixes: #631
Closes:
Related:

---

Checklist:

• Adhere to the development process
• Conform to the style guide
• Verify that the changes work as expected on real hardware
• Add automated tests cases
• Verify that all (other) automated tests (still) pass
• Update/add documentation
  • README, with "new/changed in" notes
  • applicable docs/*guide.md device guides, with "new/changed in" notes
  • liquidctl.8 Linux/Unix/Mac OS man page
  • protocol documentation in docs/developer/protocol

[sophipl]

So I wrote the solution to send the image to the AIO LCD.
However after usb reset/disconnect, the image needs to be sent twice, otherwise no effect.
One solution is to send it twice all the time.

The manufacturer software sends it twice too.

BTW I don't know why the commits went from my second account that I don't use :), probably git config thing

[aleksamagicka]

Also:

• Docs should be updated to note that GIFs are not supported on 2.X on 2023 models
• I guess test_krakenz3_screen_not_totally_broken_part2() should be updated to cover this case? (Although it's broken for other reasons right now)

Thanks!

[sophipl]

I added potential fix for test_krakenz3_screen_not_totally_broken_part2 case
However this testcase is not related to this pull request since it is about gif handling

[sophipl]

Anything else I need to do?

[sophipl]

@aleksamagicka @jonasmalacofilho please tell me what I need to do to merge this change?
I believe I addressed all @aleksamagicka points.
Sorry, I'm new to this :)

[sophipl]

I don't know if I'm supposed to do that, but I checked all items in the task, since LGTM received.

[aleksamagicka]

No need to select things that are not applicable to your PR, for example, updating the man pages if it's not needed (and I don't think it is, here).

[aleksamagicka]

Maybe link the issue #631 here, and do say that this only applies to 2023 models.

[sophipl]

How do you link issues? just hashtag in code?

[aleksamagicka]

Yes, something like *On 2023 models (standard and Elite), GIF screen mode is no longer supported for firmware versions 2.X (see #631).*

[aleksamagicka]

Actually, wait, I think the syntax is different.

[sophipl]

Well, I copied this already, and it's linked
I can change it of course

[aleksamagicka]

This works:

*On 2023 models (standard and Elite), GIF screen mode is no longer supported for firmware versions 2.X (see [#631][`issue-631`]).*

With this at the end of the file (it already has a reference to liquidtux there, so below that):

[`issue-631`]: https://github.com/liquidctl/liquidctl/issues/631

Sorry, I forgot that it doesn't automatically do that for md files.

Well, I copied this already, and it's linked

In the PR view it is, but not when you access the file normally.

[sophipl]

No need to select things that are not applicable to your PR, for example, updating the man pages if it's not needed (and I don't think it is, here).

So edit PR and remove items now?

[aleksamagicka]

No need to select things that are not applicable to your PR, for example, updating the man pages if it's not needed (and I don't think it is, here).

So edit PR and remove items now?

I don't think there's a hard and fast rule... I just leave them unchecked if they do not apply.