Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simple dependencies #412

Merged
merged 6 commits into from May 27, 2021
Merged

Remove simple dependencies #412

merged 6 commits into from May 27, 2021

Conversation

ai
Copy link
Contributor

@ai ai commented May 25, 2021

Dependencies cleaning started by @NickKaramoff. This PR will reduce the size of project dependencies and make node_modules of everyone smaller by cleaning unnecessary docs and package.json of simple dependencies.

  • indent-string because it is a simple function, which we use in a single place. The space of the package was taken mostly by package.json, docs and unnecessary for our case checks.
  • figures because we use only a few symbols. I moved them (both main and fallback versions) to a separated file.

@ai
Copy link
Contributor Author

ai commented May 25, 2021

@cenk1cenk2 test 10.x CI failed because of:

error ts-node@10.0.0: The engine "node" is incompatible with this module. Expected version ">=12.0.0". Got "10.24.1"
error Found incompatible module.

Seems like it is an issue non-relevant to this PR changes.

@cenk1cenk2
Copy link
Collaborator

cenk1cenk2 commented May 25, 2021

Thank you this is just fits on the exact path I want to take. If only we can move indent string function to utils even though it is only used in the default renderer it will be perfect. I will merge it hopefully tomorrow. Thank you for your work thst you have put in to this.

Will fix the ts node version for tests as well. Will drop support for node 10 in upcoming major release but keep it for this major version.

@ai
Copy link
Contributor Author

ai commented May 25, 2021

If only we can move indent string function to utils even though it is only used in the default renderer it will be perfect.

Done.

Thanks for the fast replies.

src/utils/indent-string.ts Outdated Show resolved Hide resolved
@ai
Copy link
Contributor Author

ai commented May 26, 2021

@cenk1cenk2 I also exported figures because lint-staged teams asked a way to sync symbols

lint-staged/lint-staged#981 (comment)

@cenk1cenk2
Copy link
Collaborator

Okay. That is no problem. Maybe today I will not have a oppurtinity to merge it since I am swamped with work but I will merge it asap.

@cenk1cenk2 cenk1cenk2 mentioned this pull request May 27, 2021
@cenk1cenk2 cenk1cenk2 merged commit f7377d2 into listr2:master May 27, 2021
@cenk1cenk2
Copy link
Collaborator

Sincerely appriciate for your time on this @ai and @NickKaramoff, thank you again.

@cenk1cenk2
Copy link
Collaborator

🎉 This PR is included in version 3.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

cenk1cenk2 added a commit that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants