-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with adding/removing SIGINT listeners #710
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #710 +/- ##
=======================================
Coverage 82.25% 82.25%
=======================================
Files 37 37
Lines 896 896
Branches 231 231
=======================================
Hits 737 737
Misses 119 119
Partials 40 40 ☔ View full report in Codecov by Sentry. |
Hmm really interesting if we you wrap whole thing and put in a variable then it finds it. Thank you for your work on this. Can you just reword the commit to start with |
8cb1efd
to
0d30480
Compare
Sure, I've just updated the commit message to start with |
🎉 This PR is included in version 8.1.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.5 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.5 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
@cenk1cenk2 Thanks for releasing this so quickly! While our company was working on integrating the new release into one of our projects, I noticed there's a lingering Do you think it should be removed? |
Closes #709
This PR fixes the problem where Listr is removing all
SIGINT
listeners, instead of just the listeners it manages. I added a "should not clear other SIGINT listeners" test and verified it failed prior to implementing the fix. Now the test passes.