fix: backport CSP support from lit/lit #1230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinfagnani any feedback on this or an estimate when it might be able to be merged in? |
|
@justinfagnani any chance you can take a look at this? |
|
Yes, I can take a look Any reason why you're still on lit-element 2.0? |
|
We're going to want a link back to the original PR from here: https://github.com/lit/lit/pull/2134/files @andy-blum we'll need to port over the test too |
|
@justinfagnani Seems like the test setup is different. Hopefully, this is at least on the right track? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#867
This PR backports the CSP support from lit/lit by adding
nonceattributes to injected stylesheets with the value ofwindow.litNonce. This should allow projects to use LitElement versions prior to 3.x.x with Safari and CSPs preventing unsafe inline styles.