Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example & spell check in content #1019

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MM25Zamanian
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Dec 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MM25Zamanian MM25Zamanian changed the title docs(lit-dev-content): spell check issues Fix example & spell check in content Dec 3, 2022
@arthurevans
Copy link
Contributor

The example changes don't look correct. It looks like you're updating one line to using Rollup 3 style but not the others. All the other examples here use Rollup 3 style, so we should leave that in place until we update.

If you want to narrow this to just fixing the typos in "regenerator" and "components", I'll take it (webcomponents is fine as one word, matching the polyfill name, or web components as two words with no hyphen).

@arthurevans arthurevans self-requested a review December 6, 2022 19:05
Copy link
Contributor

@arthurevans arthurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted above, narrow to type fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants