Add "isServer" check in observers' constructors

lit · Mar 22, 2024 · 14f8bef · 14f8bef
1 parent dd74c60
commit 14f8bef
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/packages/labs/observers/src/intersection-controller.ts b/packages/labs/observers/src/intersection-controller.ts
@@ -3,6 +3,7 @@
  * Copyright 2021 Google LLC
  * SPDX-License-Identifier: BSD-3-Clause
  */
+import {isServer} from 'lit';
 import {
   ReactiveController,
   ReactiveControllerHost,
@@ -94,6 +95,9 @@ export class IntersectionController<T = unknown> implements ReactiveController {
     }
     this._skipInitial = skipInitial ?? this._skipInitial;
     this.callback = callback;
+    if (isServer) {
+      return;
+    }
     // Check browser support.
     if (!window.IntersectionObserver) {
       console.warn(

diff --git a/packages/labs/observers/src/mutation-controller.ts b/packages/labs/observers/src/mutation-controller.ts
@@ -3,6 +3,7 @@
  * Copyright 2021 Google LLC
  * SPDX-License-Identifier: BSD-3-Clause
  */
+import {isServer} from 'lit';
 import {
   ReactiveController,
   ReactiveControllerHost,
@@ -94,6 +95,9 @@ export class MutationController<T = unknown> implements ReactiveController {
     this._config = config;
     this._skipInitial = skipInitial ?? this._skipInitial;
     this.callback = callback;
+    if (isServer) {
+      return;
+    }
     // Check browser support.
     if (!window.MutationObserver) {
       console.warn(

diff --git a/packages/labs/observers/src/performance-controller.ts b/packages/labs/observers/src/performance-controller.ts
@@ -3,6 +3,7 @@
  * Copyright 2021 Google LLC
  * SPDX-License-Identifier: BSD-3-Clause
  */
+import {isServer} from 'lit';
 import {
   ReactiveController,
   ReactiveControllerHost,
@@ -80,6 +81,9 @@ export class PerformanceController<T = unknown> implements ReactiveController {
     this._config = config;
     this._skipInitial = skipInitial ?? this._skipInitial;
     this.callback = callback;
+    if (isServer) {
+      return;
+    }
     // Check browser support.
     if (!window.PerformanceObserver) {
       console.warn(

diff --git a/packages/labs/observers/src/resize-controller.ts b/packages/labs/observers/src/resize-controller.ts
@@ -3,6 +3,7 @@
  * Copyright 2021 Google LLC
  * SPDX-License-Identifier: BSD-3-Clause
  */
+import {isServer} from 'lit';
 import {
   ReactiveController,
   ReactiveControllerHost,
@@ -93,6 +94,9 @@ export class ResizeController<T = unknown> implements ReactiveController {
     this._config = config;
     this._skipInitial = skipInitial ?? this._skipInitial;
     this.callback = callback;
+    if (isServer) {
+      return;
+    }
     // Check browser support.
     if (!window.ResizeObserver) {
       console.warn(