test (labs/ssr): add tests for package exports resolution

lit · Oct 19, 2022 · 2e13a38 · 2e13a38
1 parent 8b0ad8f
commit 2e13a38
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 1 deletion.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/labs/ssr/src/lib/module-loader.ts b/packages/labs/ssr/src/lib/module-loader.ts
@@ -278,6 +278,7 @@ export const resolveSpecifier = async (
       modules: ['node_modules'],
       extensions: ['.js'],
       mainFields: ['module', 'jsnext:main', 'main'],
+      conditionNames: ['node'],
     });
     return pathToFileURL(modulePath);
   }

diff --git a/packages/labs/ssr/src/test/lib/module-loader_test.ts b/packages/labs/ssr/src/test/lib/module-loader_test.ts
@@ -53,4 +53,38 @@ test('loads a module with a built-in import', async () => {
   assert.ok(module.namespace.join);
 });
 
+test('resolves an exact exported path', async () => {
+  const loader = new ModuleLoader({global: window});
+  const result = await loader.importModule('./lit-import.js', testIndex);
+  const {module, path: modulePath} = result;
+  assert.is(module.namespace.litIsServer, true);
+  assert.ok(loader.cache.has(modulePath));
+  const isServerPath = path.resolve(
+    path.dirname(testIndex),
+    '../../../../../lit-html/node/is-server.js'
+  );
+  assert.ok(loader.cache.has(isServerPath));
+});
+
+test('resolves a root exported path (.)', async () => {
+  const loader = new ModuleLoader({global: window});
+  const result = await loader.importModule(
+    './lit-import-from-root.js',
+    testIndex
+  );
+  const {module, path: modulePath} = result;
+  assert.is(module.namespace.litIsServer, true);
+  assert.ok(loader.cache.has(modulePath));
+  const litPath = path.resolve(
+    path.dirname(testIndex),
+    '../../../../../lit/index.js'
+  );
+  const isServerPath = path.resolve(
+    path.dirname(testIndex),
+    '../../../../../lit-html/node/is-server.js'
+  );
+  assert.ok(loader.cache.has(litPath));
+  assert.ok(loader.cache.has(isServerPath));
+});
+
 test.run();
diff --git a/packages/labs/ssr/src/test/test-files/module-loader/lit-import-from-root.js b/packages/labs/ssr/src/test/test-files/module-loader/lit-import-from-root.js
@@ -0,0 +1,2 @@
+import {isServer} from 'lit';
+export const litIsServer = isServer;
diff --git a/packages/labs/ssr/src/test/test-files/module-loader/lit-import.js b/packages/labs/ssr/src/test/test-files/module-loader/lit-import.js
@@ -0,0 +1,2 @@
+import {isServer} from 'lit-html/is-server.js';
+export const litIsServer = isServer;