Address feedback

lit · Jan 31, 2024 · 5adce21 · 5adce21
1 parent e6bf564
commit 5adce21
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/packages/labs/eslint-plugin/package.json b/packages/labs/eslint-plugin/package.json
@@ -33,7 +33,7 @@
       "clean": "if-file-deleted"
     },
     "test": {
-      "command": "node --enable-source-maps --test-reporter=dot --test test/**/*_test.js",
+      "command": "node --enable-source-maps --test-reporter=spec --test test/**/*_test.js",
       "dependencies": [
         "build"
       ],

diff --git a/packages/labs/eslint-plugin/src/lib/util.ts b/packages/labs/eslint-plugin/src/lib/util.ts
@@ -15,6 +15,7 @@ import ts from 'typescript';
 import * as path from 'path';
 
 export const createRule = ESLintUtils.RuleCreator(
+  // TODO (justinfagnani): set up rule doc publishing pipeline for lit.dev
   (name: string) => `https://lit.dev/eslint-plugin/${name}`
 );
 
@@ -29,7 +30,6 @@ export const getAnalyzer = (services: ParserServicesWithTypeInformation) => {
       getProgram: () => program,
       fs: ts.sys,
       path,
-      // basePath,
     });
   }
   return analyzer;

diff --git a/packages/labs/eslint-plugin/src/rules/attribute-names.ts b/packages/labs/eslint-plugin/src/rules/attribute-names.ts
@@ -55,7 +55,6 @@ export const attributeNames = createRule({
           return;
         }
         const properties = declaration.reactiveProperties;
-        // const propertyMap = getPropertyMap(node);
 
         for (const [propertyName, property] of properties.entries()) {
           const attributeOptionNode = property.optionsNode?.properties.find(